Added a stopwatch to the magic number checks #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
magic-number-perf
branch
from
ead48b2 to
ce1cffb
Compare
Mailaender
force-pushed
the
magic-number-perf
branch
from
ce1cffb to
c3fd838
Compare
|
It looks good. As logging also consumes processor time and space for the log file on disk, we could probably add a system option to enable/disable the MagicNumberMatcher logging on demand. |
|
Yes, I was a bit torn on it as a check against the preferences will also cost CPU (haven't profiled any of it) so maybe increasing |
|
Yep, good idea. Let's keep it so far as it is. If we discover performance issues due to the stopwatch, we could have a look at this again. There are several ways, how to address it:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to investigate OpenChrom/openchrom#101.