Remove obsolete compiler option assignments

[mehmet-karaman]

This should fix the compilation errors caused by removed CompilerOptions in Jdt.

[cdietrich]

Which is the minimal jdt version
This removal requires
Last time we needed to use reflection

[cdietrich]

@mehmet-karaman can we check if there is more stuff that is marked for removal and is in @iloveeclipse delete queue

[mehmet-karaman]

oo .. You're right.. I guess currently it compiles against the latest jdt... but it has to be conform until 2022-03, right?

[mehmet-karaman]

If the build is green, please don't merge this.

[cdietrich]

Yes. Depending if the team finds time to work on the j17 minimum story

[mehmet-karaman]

Are there tests which are running on 2022-03? How we can recognize if we break something on older platform versions?

[cdietrich]

yes the one on ci.eclipse.org/xtext (continuous-integration/jenkins/pr-head)

[cdietrich]

but am not sure how good overage is.

[github-actions]

Test Results

  6 460 files  +  3 868    6 460 suites  +3 868   3h 9m 4s ⏱️ + 2h 42m 22s
 43 242 tests + 34 497   42 658 ✅ + 33 973    584 💤 +  524   0 ❌ ± 0 
170 304 runs  +137 924  167 936 ✅ +135 803  2 358 💤 +2 111  10 ❌ +10 

Results for commit ffc3b15. ± Comparison against base commit 4e00f55.

♻️ This comment has been updated with latest results.

[LorenzoBettini]

What does that field mean? Is in general only setting the sourceLevel, without the originalSourceLevel enough (even in the past)?

[cdietrich]

https://ci.eclipse.org/xtext/job/xtext/job/PR-3206/1/

Ton of test fails

[LorenzoBettini]

https://ci.eclipse.org/xtext/job/xtext/job/PR-3206/1/

Ton of test fails

OK, I see.

Another good candidate to be inserted here #3204 ;)

[mehmet-karaman]

I've contacted @iloveeclipse and Srikant they've said that it is obsolete since version 4.33 .. So for all versions before 4.33 we have to do the reflective workaround. I've also asked if there are any CompilerOptions planned for removal, he said that nothing will be removed for now.

He also added that @cdietrich did similar workarounds for something with JSR .. The same has to be done in this case

[mehmet-karaman]

I've found the PR which mentions something with JSR .. I am going to mimik this for the two compiler options..

#3189

[cdietrich]

@mehmet-karaman please note we had to rewrite that one 5 times.
please do the same as its currently on main.
see the

if (INLINE_JSR_BYTECODE != null) {
			try {
				INLINE_JSR_BYTECODE.invoke(this.compilerOptions, true);
			} catch (Throwable e) {
				// ignore
			}
		}

[mehmet-karaman]

Just a sidenote:
While checking the occurences, I've seen that JDT marked the following constant as deprecated:
JavaCore.COMPILER_CODEGEN_INLINE_JSR_BYTECODE

Might be we also get problems with that in the future..

[mehmet-karaman]

@cdietrich is this build ok now? Changed the state of this PR from draft to open..

[cdietrich]

Will check when Jenkins is though and I am back from lunch nd meeting

[mehmet-karaman]

:) finally all green

[cdietrich]

thx @mehmet-karaman can you rebase the other one