replace obsolete reflection usage with original method calls #3205
Conversation
|
@mehmet-karaman can you please rebase this on the lastest main |
Test Results 6 460 files ± 0 6 460 suites ±0 3h 9m 28s ⏱️ - 5m 10s For more details on these failures, see this check. Results for commit 70baf17. ± Comparison against base commit 531d040. ♻️ This comment has been updated with latest results. |
mehmet-karaman
force-pushed
the
replace_reflection_by_original_method_calls
branch
from
1b4ad9f to
ef1576c
Compare
|
rebase done. |
|
Something looks really odd.. I am going to check that.. |
|
no idea what is happening here neither |
|
@mehmet-karaman can you try to ammend the commit with a new date e.g. |
|
No, I use egit "Rebase interactive" for rebasing. Maybe my fork is not correctly in sync.. |
|
github says it is |
|
git command would be |
mehmet-karaman
force-pushed
the
replace_reflection_by_original_method_calls
branch
from
ef1576c to
20314d1
Compare
|
seems to have helped. jobs started again. lets see what happens |
|
I don't understand the original problem: the build had restarted with no failure. Now the build fails with a compilation error: has jdt just removed a field from CompilerOptions? |
|
eclipse-jdt/eclipse.jdt.core@59bc0be This one seems to be the commit, which breaks it. |
|
@iloveeclipse is there any suggestion what we can use instead of CompilerOptions.originalComplianceLevel ? Maybe a new commit with CompilerOptions.complianceLevel instead of CompilerOptions.originalComplianceLevel ? |
|
the compilation error should be fixed with the other PR: If the CompilerOptions are obsolete, then logically they are also obselete for xtext.. or isn't it? |
|
Does the removal work with old jdt s |
|
See the other issue from 2 weeks ago |
|
Since the least java version was set to 1.8 it should work with older versions.. The addSuppressed method is visible in java 1.8 so it shuld work. The other changes were regarding the workarounds for eclipse oxygen and older, which isn't supported anymore.. So my viewpoint is that it should work with all supported jdk's and eclipse versions. |
mehmet-karaman
force-pushed
the
replace_reflection_by_original_method_calls
branch
from
d4b2a1d to
404bc8d
Compare
mehmet-karaman
force-pushed
the
replace_reflection_by_original_method_calls
branch
from
404bc8d to
f42b536
Compare
mehmet-karaman
force-pushed
the
replace_reflection_by_original_method_calls
branch
from
f42b536 to
70baf17
Compare
|
@cdietrich do you have an idea why there are test failures? My branch is up to date, nothing to rebasese.. The build was successful before I've added this method back, so the failures makes no sensee for me. |
|
no. i have restarted the job |
|
thx @mehmet-karaman |
Replaced some/ Adjusted reflection usages.