Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lemminx to 0.28.0 #1628

Merged

Conversation

martinlippert
Copy link
Contributor

The lemminx language server in version 0.27.0 throws a nasty error in some cases (see eclipse-lemminx/lemminx#1653) that has been fixed on 0.28.0, so updating to that version would be awesome.

@mickaelistria
Copy link
Contributor

The eslint failures are not related, let's merge.

@mickaelistria mickaelistria merged commit d30c384 into eclipse-wildwebdeveloper:master Jul 19, 2024
3 of 6 checks passed
@martinlippert
Copy link
Contributor Author

Awesome, thanks @mickaelistria. Any idea when a new release build might be around that includes this upgrade? Any plans?

@mickaelistria
Copy link
Contributor

I think we can release as soon as the 4 failing ESLint tests are resolved. However, I'm not aware of anyone looking at them nor planning to look at them on short term. If you can spend a bit of time investigating those, that would be helpful.

@martinlippert
Copy link
Contributor Author

I think we can release as soon as the 4 failing ESLint tests are resolved. However, I'm not aware of anyone looking at them nor planning to look at them on short term. If you can spend a bit of time investigating those, that would be helpful.

I will most likely not be able to spend time on this myself at the moment (vacation coming up), but I will ask someone from the team to support here.

@mickaelistria
Copy link
Contributor

We have reverted the change that was causing the 4 failures, so no further work is needed here.
The current issue that prevents from a release is some IP approval for some NPM dependencies (I don't remember which ones and the build log isn't verbose enough to figure it out)

@martinlippert
Copy link
Contributor Author

We have reverted the change that was causing the 4 failures, so no further work is needed here. The current issue that prevents from a release is some IP approval for some NPM dependencies (I don't remember which ones and the build log isn't verbose enough to figure it out)

Alright, thanks for that update. Looking forward to the IP approval and a new release build sometime afterwards then... :-) Many many thanks!!!

@laeubi
Copy link

laeubi commented Nov 7, 2024

I have one question, before it seems m2e has provided the lemminx version via extension point

<plugin>
   <extension
         point="org.eclipse.wildwebdeveloper.xml.lemminxExtension">
      <jar
            path="...the jar...">
      </jar>
      <classpathExtensionProvider
            provider="org.eclipse.m2e.editor.lemminx.MavenRuntimeClasspathProvider">
      </classpathExtensionProvider>
      <initializationOptionsProvider
            provider="org.eclipse.m2e.editor.lemminx.InitializationOptionsProvider">
      </initializationOptionsProvider>
   </extension>
</plugin>

but this seem to no longer work, what ever I tried out I end up with:

INFORMATION: Initializing XML Language server
LemMinX Server info:
 - Version : 0.28.0
 - Java : /opt/java/jdk-21
 - VM Version : 21
 - Git 9c3a0f1 - [maven-release-plugin] prepare release 0.28.0

if I delete the jar then the server seem to fail to start, but beside from that the jar needs to be there it somehow always seem to load the "old" (current released) version.

@laeubi
Copy link

laeubi commented Nov 7, 2024

I just found out that this is only for lemminx-maven (not lemminx itself) ... What seem to work is find out where Equinox extracts the bundle content, then replace the org.eclipse.lemminx-uber.jar there so quite inconvenient...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants