-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update lemminx to 0.28.0 #1628
update lemminx to 0.28.0 #1628
Conversation
The eslint failures are not related, let's merge. |
d30c384
into
eclipse-wildwebdeveloper:master
Awesome, thanks @mickaelistria. Any idea when a new release build might be around that includes this upgrade? Any plans? |
I think we can release as soon as the 4 failing ESLint tests are resolved. However, I'm not aware of anyone looking at them nor planning to look at them on short term. If you can spend a bit of time investigating those, that would be helpful. |
I will most likely not be able to spend time on this myself at the moment (vacation coming up), but I will ask someone from the team to support here. |
We have reverted the change that was causing the 4 failures, so no further work is needed here. |
Alright, thanks for that update. Looking forward to the IP approval and a new release build sometime afterwards then... :-) Many many thanks!!! |
I have one question, before it seems m2e has provided the lemminx version via extension point
but this seem to no longer work, what ever I tried out I end up with:
if I delete the jar then the server seem to fail to start, but beside from that the jar needs to be there it somehow always seem to load the "old" (current released) version. |
I just found out that this is only for lemminx-maven (not lemminx itself) ... What seem to work is find out where Equinox extracts the bundle content, then replace the |
The lemminx language server in version 0.27.0 throws a nasty error in some cases (see eclipse-lemminx/lemminx#1653) that has been fixed on 0.28.0, so updating to that version would be awesome.