Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when edit spring xml bean config file #1295

Closed
batobolg opened this issue Jul 18, 2024 · 9 comments
Closed

Error when edit spring xml bean config file #1295

batobolg opened this issue Jul 18, 2024 · 9 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: xml-support type: bug

Comments

@batobolg
Copy link

When edit spring XML bean config file it got error

image

the language server setting is
image
spring xml setting is ON
image
and error log is
image

@batobolg
Copy link
Author

The java project is so simple for test this,
I have just one java file like this
image

@martinlippert martinlippert added theme: xml-support status: needs-investigation for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Jul 18, 2024
@martinlippert martinlippert self-assigned this Jul 18, 2024
@martinlippert martinlippert added this to the 4.24.0.RELEASE milestone Jul 18, 2024
@martinlippert
Copy link
Member

It looks like we have two problems here:

  • the generic XML tooling (Eclipse Lemminx project) throws the error (for unknown reasons, the overall content-assist from that XML language server works nicely)
  • the Spring content-assist for these XML elements doesn't work correctly, returns an empty list of proposals

Need to investigate this further...

@martinlippert
Copy link
Member

Filed this for the XML language server: eclipse-lemminx/lemminx#1653
Now need to investigate the empty response from the Spring Boot language server for this...

@martinlippert
Copy link
Member

The content-assist from the Spring Boot language server seems to work. It returns an empty list of completions if you don't have prefix (due to too many results would be produced to be useful), but as soon as you start to type, the content-assist shows up nicely. But the error coming from the XML language server actually prevents those proposals from showing up.

You can try (and verify) that by disabling the general XML language server in the Preferences -> Language Servers - just to verify. It is not really a useful workaround, since you loose all the general XML content-assist features if you disable the XML language server.

I will probably also follow-up with the lsp4e project to see what could be done to avoid a situation where one language server that reports an error basically destroys the whole experience, even if other language servers work just fine.

@martinlippert
Copy link
Member

Here is the issue raised against lsp4e: eclipse-lsp4e/lsp4e#1038

@batobolg
Copy link
Author

disabling the general XML language server , the java class name and property pops out it good,
image
but xml suggestions totally gone, it is true because we disabling the general XML language server.

@martinlippert
Copy link
Member

Thanks for verifying that disabling the XML language server brings back the Spring specific code completions. It is indeed no real workaround, so we are working on a fix for LSP4E (to show proposals in case one language server throws an error), which would be a reasonable fix here.

In addition to that the Lemminx XML language server project should also look into the error and fix it, but with the fix in LSP4E we would not need to wait for that.

@martinlippert
Copy link
Member

So the problem in the XML language server is already fixed, now we need to include a new release of the Wild Web Developer components that includes the Lemminx XML language server. Created this PR for the necessary update in WWD: eclipse-wildwebdeveloper/wildwebdeveloper#1628

@martinlippert
Copy link
Member

The PR for WWD got merged, so waiting for a new release build of the WWD components now.
In addition to that, the fix for LSP4E also went in, so we will include a snapshot build of that for the next Spring Tools release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: xml-support type: bug
Projects
None yet
Development

No branches or pull requests

3 participants