-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse existing allocators, enable experimental adaptive one and enable SSL heap pooling (Fixes #5168) #5262
Conversation
44354d0
to
4265ae0
Compare
@He-Pin do you think this could be useful to use to try the adaptive pool with vertx? |
@franz1981 Why is the heap buffer not pooled, shouldn't it be a almost free lunch in performance? |
IDK I would love to know it from @vietj probably there's some historical reason for that but I would like to know it. |
@vietj this is adding the option to enable heap pooling when SSL is enable, which can be a saviour with JDK SSL, see quarkusio/quarkus#41880 (comment) |
src/main/java/io/vertx/core/buffer/impl/VertxByteBufAllocator.java
Outdated
Show resolved
Hide resolved
0a7ad40
to
ba8c032
Compare
PTAL @vietj |
Not good @vietj
not sure the engine options is the right place for that configuration flag...let's see what I can do here... |
ba8c032
to
094f68d
Compare
…eap JDK SSL heap buffer pooling (Fixes eclipse-vertx#5168)
094f68d
to
afafb7a
Compare
I've decided to split in 3 separate PRs this effort, to make it easier to integrate (and test)! |
Fixes #5168