feat: helm chart structure check #32
Conversation
…ng UT for repo structure check
| } | ||
|
|
||
| func CleanFiles(files []string) { | ||
|
|
There was a problem hiding this comment.
Unnecessary blank line
| } | ||
|
|
||
| return &txqualitychecks.QualityResult{Passed: true} | ||
| } | ||
|
|
||
| // Function to verify files existance. | ||
| // Return missing ones. | ||
| func checkMissingFiles(listOfFiles []string) []string { | ||
| func CheckMissingFiles(listOfFiles []string) []string { |
There was a problem hiding this comment.
like the functions below, I would move this to a dedicated package
| } | ||
|
|
||
| func (r *HelmStructureExists) Test() *txqualitychecks.QualityResult { | ||
|
|
There was a problem hiding this comment.
I see this on multiple of your files. The empty blank lines at the beginning of the function seems unnecessary for me.
| if hc.IsDir() { | ||
| tmpFilesStructure := []string{} | ||
| for _, fname := range helmStructureFiles { | ||
| tmpFilesStructure = append(tmpFilesStructure, mainDir+"/"+hc.Name()+"/"+fname) |
There was a problem hiding this comment.
path.Join() would be a good option here instead of concatenating "/" manually. This also takes care of potentially already existing slashes at the end of your path fragments
|
|
||
| func CreateDirs(dirs []string) { | ||
| for _, dir := range dirs { | ||
| os.Mkdir(dir, 0750) |
There was a problem hiding this comment.
Be careful with Mkdir. It is only capable of creating one level of dirs. MkdirAll could be a better option
| message := startingMessage | ||
| for _, missingFile := range listOfFiles { | ||
| message += missingFile + " " | ||
| func CreateFiles(files []string) { |
There was a problem hiding this comment.
Either do not export these functions, since it is only used in this package, or create a separate filesystem (or better name) package
tomaszbarwicki
force-pushed
the
feat/add_helmchart_structure_check
branch
from
51e65c7 to
7282799
Compare
Description
Introducing new check as per TRG 5.02 - Chart structure.
The check verifies if repository follows specified Helm Chart files & directory structure.
Fixes eclipse-tractusx/sig-infra#94
Updates eclipse-tractusx/sig-infra#93
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
Additional information