Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomasz: Commiter #93

Closed
FaGru3n opened this issue Jun 22, 2023 · 10 comments · Fixed by eclipse-tractusx/tractusx-quality-checks#19
Closed

Tomasz: Commiter #93

FaGru3n opened this issue Jun 22, 2023 · 10 comments · Fixed by eclipse-tractusx/tractusx-quality-checks#19
Assignees

Comments

@FaGru3n
Copy link
Contributor

FaGru3n commented Jun 22, 2023

PR

@FaGru3n FaGru3n added the tasks label Jun 22, 2023
@FaGru3n FaGru3n added this to the committer milestone Jun 22, 2023
@FaGru3n FaGru3n removed this from the committer milestone Jun 26, 2023
@FaGru3n FaGru3n added refined and removed tasks labels Jun 26, 2023
@tomaszbarwicki
Copy link
Contributor

tomaszbarwicki commented Jun 28, 2023

[deleted]

@tomaszbarwicki
Copy link
Contributor

@florianrusch-zf
Copy link

florianrusch-zf commented Sep 19, 2023

Firstly, thank you @tomaszbarwicki for compiling the list of contributions! Looks promising 🙂

But in general I have a questions regarding this approach: @Siegfriedk, @FaGru3n, and @theOtherCommitters, does this seem like an overly spammy way to list contributions? Each linked issue now contains the following line. So far the list has been perfectly adequate for the election, in my opinion. What are your thoughts on this?

image

Of course this approach may suffice, however, consider a scenario where 20 or more contributors wish to become committers and generate a GitHub issue linking multiple issues and PRs. Is this really beneficial? Of course, there is nothing inherently wrong with this approach. In my opinion, the list of contributions serves only a temporary purpose for the election only (please correct me if I'm wrong!). Afterwards, the list is entirely outdated and there is no reason to preserve it anywhere (certainly not in the form of a GitHub issue).

However, this is solely my personal opinion. I am eager to hear your thoughts on this.

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Sep 19, 2023

Hi @florianrusch-zf i agree that the menitioning withing the related issue looks not ideal, because it will suggest the person is only doing it to become a committer.

In Fact is is just a list to get all the contributions and commits, for maybe upcomming proposal to become a committer and makes the life of the proposing person a bit easier, because he/she can just visit this issue collections with all contributions he/she did...

Other idea would be the listing in everyones personal profile to get an overview from the contributions to eclipse tractus-x e.g. my profile listing but then everyone have to agree this to share it also with the world, which contributions he/she has made.
image

Or how do you would save a list of contributions to become a committer?

@Siegfriedk
Copy link
Contributor

Siegfriedk commented Sep 20, 2023

Its quite normal to reference and cross reference other issues.

We try to be as transparent as possible with the committer election and normally this is a temporar thing.

For me its worth it to keep it as it is

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Sep 25, 2023

election done, think @Siegfriedk need this for some paperwork

@Siegfriedk
Copy link
Contributor

@FaGru3n election is done but PMC approval is sitill missing

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Sep 26, 2023

@FaGru3n election is done but PMC approval is sitill missing

this is what i try to mention 😉

@FaGru3n FaGru3n closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants