Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjusted BPN validations on different operators #1456

Conversation

danielkenji01
Copy link
Contributor

@danielkenji01 danielkenji01 commented Jul 23, 2024

WHAT

  • Fixed IS_ALL_OF operator validation. It had the same behavior of EQ operator
  • Fixed IS_NONE_OF operator validation. It had the same behavior of the NEQ operator
  • Fixed NEQ operator validation. It was considering the opposite result of the IN operator, and it should be the opposite of the EQ operator
  • Removed a validation that returned false when the list of assigned groups is empty. This should be evaluated by the operators.

WHY

In order to keep the correct behavior on BPNL validations

FURTHER NOTES

Some minor adjusts reported by Sonar, including:

  • Adjusted String format and casting

Closes ##1411
Closes ##775

@paullatzelsperger paullatzelsperger self-requested a review July 24, 2024 06:29
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: don't just change unrelated code, don't use final except for field declarations

@paullatzelsperger paullatzelsperger force-pushed the main branch 2 times, most recently from a82abc5 to 5e07cbf Compare July 24, 2024 07:24
@paullatzelsperger paullatzelsperger force-pushed the main branch 2 times, most recently from 9578e98 to 8a5aa9d Compare July 24, 2024 07:31
@danielkenji01
Copy link
Contributor Author

TL;DR: don't just change unrelated code, don't use final except for field declarations

Thank you for the comments, I followed them and adjusted the code.

@paullatzelsperger
Copy link
Contributor

please resolve conversations that you fixed, and then re-request the review

Copy link

sonarqubecloud bot commented Aug 8, 2024

@paullatzelsperger paullatzelsperger merged commit c4e30eb into eclipse-tractusx:main Aug 13, 2024
34 checks passed
@danielkenji01 danielkenji01 deleted the fix/bpnl-isAllOf-validation branch August 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants