Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPNL Validation function evaluates the same way for EQ and isAllOf operators #1411

Closed
rafaelmag110 opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rafaelmag110
Copy link
Contributor

rafaelmag110 commented Jul 9, 2024

Describe the bug

Using the isAllOf operator in a policy, the validation fails if a BPNL belongs to more groups than the ones specified in the policy.

In the BPNL validation extension, the validation function evaluates the EQ and the isAllOf operators in the same way, however even the documentation states they should evaluate the groups differently, as shown in the expected behaviour.

Also, in the BusinessPartnerGroupFunctionTest class, the following circumstance is tested:
Arguments.of("Overlapping groups", IS_ALL_OF, List.of(TEST_GROUP_1, TEST_GROUP_2, "different-group", "another-different-group"), false)

And being TEST_GROUP_1 and TEST_GROUP_2 part of the allowed groups, this case should return true and not false

Expected behavior

Operator EQ: must be exactly in - and only in - that particular group or set of groups
Operator IS_ALL_OF: must be in all of the specified groups

@rafaelmag110 rafaelmag110 added bug Something isn't working triage all new issues awaiting classification labels Jul 9, 2024
@danielkenji01
Copy link
Contributor

Can I assign this issue to me? @ndr-brt @rafaelmag110

@lgblaumeiser
Copy link
Contributor

Please have a look at: eclipse-tractusx/sig-release#775 (comment), there is an additional issue with operators

@danielkenji01
Copy link
Contributor

danielkenji01 commented Aug 13, 2024

The issue was solved on the following Pull Request: #1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants