[Backend] Validation of Edit Notification Workflow

[ds-mwesener]

As ... , a supervisor
I want ... , to have a working edit notification workflow
so that ... . I can use it for editing notifications.

Specification

https://confluence.catena-x.net/pages/viewpage.action?pageId=69429778

Relates to

#622

Hints / Details

• Within Create Edit Notification View #622 we did not implement business validation because story was already to high estimated.
• Question to be clarified:
  • Is it allowed to remove all parts for investigations?
    • see specification (atleast one)
  • Is it allowed to remove all parts for alerts?
    • see specification (atleast one)
  • As the BPN is an optional field an alert will fail it not provided because we cannot retrieve a valid bpn for a receiver, how to handle this?
    • Suggestion by dev: Investigation (BPN = mandatory), Alert (BPN = mandatory)
• check if FE validation is aligned

Acceptance Criteria

• Implementation done related to decision

Out of Scope

• ...

[ds-mwesener]

Backend throws now a bad request if the affectedParts or bpn is missing from the create and edit notification request.
The frontend does not allow to create or edit the notification if those values are missing.

[ds-crehm]

Removing / adding parts in "edit notification" does not work for investigations.

BPN validation does not work properly when creating:

It doesn't work properly when updating either:

The error message should be in English. And the order of the sentences should be consistent.

[ds-mwesener]

Message will be translated. 👍
If bpn is missing only the message about the missing attribute is shown. 👍
If the bpn is existing and wrong formatted only the error regarding the wrong format will be displayed 👍
No assets attached will lead to a bad request and not 500. 👍
Pagination changes does not trigger a reload of the assets and will stuck in loading screen. 👍

[ds-crehm]

Error message is a lot better now. It can now be differentiated between having a missing or invalid BPN:


All other issues have been fixed.
Ready for review.