Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Notification Create/Edit: Adapting AssetsAsBuilt API to allow filtering for partIds (affectedParts) and (available parts) #834

Closed
ds-mwesener opened this issue Apr 9, 2024 · 2 comments
Assignees
Labels
backend Backend related issues frontend Frontend related Issues

Comments

@ds-mwesener
Copy link
Contributor

ds-mwesener commented Apr 9, 2024

As ... , a user
I want ... , to see only affected parts on my notification
so that ... I have control what asset is within my notification

Link

Hints / Details

  • Currently while creating / editing an existing notification the affected part table (top right corner) is filtered in the frontend. This leads to several issues.
    • Pagination (is not correct as frontend filters data)
    • Autocomplete Filter (shows all available assets and not only affected assets)

When we use the assetAsBuilt API to retrieve assets additionally filtered by the affectedPartIds then the frontend pagination is fixed and we do not need to filter this data in frontend.

Additionalliy to fix the autocomplete issue we would also need to adapt the input to accept a assetId to only show autocomplete suggestions based on available data in the affectedParts table.

Acceptance Criteria

  • Pagination of affected part works.
  • Frontend uses the backend filter mechanism to:
    • only get a subset of the parts (affected parts) to control this it will use the affectedPartIds as filter on all assetsAsBuilt.
    • only get a subset of the parts (available parts) to control this we give the affectedPartIds as a exclusion filter to the assets api
  • Backend accepts a list of asset ids which should be excluded from the result set of assets api (to be able to filter the available parts by the parts which have been moved to the affected parts table)
  • GIVEN Edit or Create Notification Dialog is open WHEN adding assets from available parts to affected parts table the assets are removed from available parts table
    GIVEN Edit or Create Notification Dialog is open WHEN removing parts from affected parts the assets are added to available parts table

Out of Scope

  • ...
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Apr 9, 2024
@mkanal mkanal moved this from inbox to test in Trace-X Apr 15, 2024
@mkanal mkanal moved this from test to inbox in Trace-X Apr 15, 2024
@ds-mwesener ds-mwesener changed the title [Backend] Notification Create/Edit: Adapting AssetsAsBuilt API to allow filtering for partIds (affectedParts) [Backend] Notification Create/Edit: Adapting AssetsAsBuilt API to allow filtering for partIds (affectedParts) and (available parts) Apr 16, 2024
@ds-mwesener ds-mwesener added frontend Frontend related Issues backend Backend related issues labels Apr 16, 2024
@ds-mwesener ds-mwesener moved this from inbox to next in Trace-X Apr 16, 2024
@ds-mwesener ds-mwesener self-assigned this Apr 16, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X Apr 16, 2024
@ds-mwesener
Copy link
Contributor Author

Moved one acceptance critieria to #859 as it needs to be resolved there.

@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Apr 17, 2024
@ds-mwesener ds-mwesener removed their assignment Apr 17, 2024
@ds-crehm
Copy link
Contributor

Tested on E2E.
Pagination works. Filter mechanism works.
Some problems are present. Those are already addressed here: #844
This issue is ready for review and I will retest 844 once the issues are resolved.

@ds-crehm ds-crehm moved this from test to review in Trace-X Apr 25, 2024
@jzbmw jzbmw moved this from review to done in Trace-X Apr 30, 2024
@jzbmw jzbmw closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues frontend Frontend related Issues
Projects
Status: done
Development

No branches or pull requests

3 participants