Create Edit Notification View

[ds-mmaul]

As user ,
I want to edit existing notifications before sending,
so that i dont have to recreate a notification .

Link

• relates to [Backend] Notification Create/Edit: Adapting AssetsAsBuilt API to allow filtering for partIds (affectedParts) and (available parts) #834
• relates to Page Exit Confirmation on "Back" Button for editable Views to prevent unintended data loss #835
• relates to [Frontend] Add table settings to edit notification view #836
• relates to Create Edit Notification View #622
• relates to [TESTING] INT Tests for feature "Edit Notification" #853

Hints / Details

• Miro UI Concept Board : LINK

• from concept in Create Concept for Edit Parts View for notifications #621
• Give input to component (parts)

Acceptance Criteria

• Edit Notification View is implemented as in concept LINK
• The following notification info (see concept mock)
  -- description
  -- title
  -- sendTo / BPN
  -- target date
  -- severity
  -- parts
• BE Api for editing parts of notifications is implemented as in concept concept in repo
• Add the possibility to add a incident name to an incident max 2000 Char
• Documentation has been updated -> will be added after Create dedicated 'Create Notification View' #623
• Add Incident name to the different views and tables

BPN input will be in the left side formular.
Add / Delete Parts will be only within an action menu button bar on top left corner
Top table is only view
Bottom table is selectable
Buttons will be replaced to icons within the #623
Target Date will be completly handled by #623 please do not test

Out of Scope

• ...

[jzbmw]

Decision Edit and Create View on a Notification has been rearanged so that parts is on the right and all other info on the left side

[ds-mwesener]

Open questions:

• Modal vs. View (like Detail View).
  -> View
• Button "Edit" outside like view details and inside
  -> Yes
• Edit parts section, like discussed
• What are the restriction of the parts which should be addable? E.g. asBuilt, bpn?
  -> only as built, if investigation then only supplier parts, if alert then only own parts
• Currently target date is only supported by investigations not alerts - allow it for both?
  -> both
• Currently BPN is only allowed within alerts not investigations - allow it for both?
  -> both
• Decision needed label can be removed? Because all fields are editable.
  -> removed

Out of scope

• Currently we only support one BPN as input, if necessary we should add a new story for the behaviour of accepting multiple bpns.

@jzbmw I will bring this up in a parking lot. FYI

Has been discussed in parking lot on 03.04.2024

[ds-mwesener]

Current todos:

• Remove button needs to be clicked two times (affected parts) 👍
• Owner Parts for Alerts 👍
• Supplier Parts for Investigation 👍
• Definition of selection behaviour -> After click selection will be reset 👍
• Autocomplete does not show correct results (only type of owner should be correct - but full response of all parts) 👍
• Pagination for affected parts 👍
• Save button needs to be disabled on invalid form 👍
• Toast including success / error message 👍
• Add button disabled if nothing selected 👍
• Remove button disabled if nothing selected 👍
• Styles applied for buttons
• Tooltips on all actions (disabled) 👍
• Rename request properties of create notification 👍
  • partIds -> affectedPartIds
• Remove request properties of create notification 👍
  • isAsBuilt
• Rename request properties of edit notification 👍
  • bpn-> receiverBpn
  • affectedParts -> affectedPartIds
  • Detail view does not load supplier parts

We need a concept for handling autocomplete filter in a pure frontend data table, because it is designed for quering against backend api. Additionally we need to implement a pure frontend pagination.

[ds-mwesener]

Story derived from the current one: #843

As it was decided to not implement validation in backend because it was not refinement I have also derived a story for this topic: #844

[ds-mwesener]

Feedback by Christian:

1. Admin / User should not be able to edit -> disable and tooltip 👍
2. SENT TO name should be name not bpn 👍
3. After leaving an edited notification we need to update the selected notification object by requesting the backend - otherwise parts are not updated in detail view : 👎 -> Create dedicated 'Create Notification View' #623
4. Hover on input leads to label instead of translation (edit view) 👍 -> Create dedicated 'Create Notification View' #623
5. Remove / Add Button Tooltip is bad located 👍 -> Create dedicated 'Create Notification View' #623
6. Tooltip is on container in create form which should only be on text 👍 -> Create dedicated 'Create Notification View' #623
7. Title needs to be null if empty otherwise bad request 👍
8. Text Area of create form can be resized bigger than container 👎 -> Create dedicated 'Create Notification View' #623
9. Labels on Input should always have dot. 👍
10. Title Edit notification (case) 👍
11. Label of Quality Type (case) 👍
12. Input hint Characters (case) 👍
13. Performance -> Will be solved with: [Backend] Notification Create/Edit: Adapting AssetsAsBuilt API to allow filtering for partIds (affectedParts) and (available parts) #834
14. Edit button should be disabled in detail view of a notification if it fullfills requirement of state (CREATED) 👍

[ds-mwesener]

From technical perspective we will accept the performance limitations as it is complex to solve and will be either way solved with the mandatory story: #834

[mkanal]

Testing

• User: Admin has no permission to execute action "Edit notification" in all views
• User: Supervisor has permission to execute action "Edit notification" in all views
• User: User has permission to execute action "Edit notification" in all views
• User: Supervisor : Paginate to second page > Edit notification > Back : Page 2 is displayed with edit part

[mkanal]

Same tooltip on both actions addressing the same table. Expected table name is specified.

Tooltip should guide the user why the action is not executable.

Validation of form is no sufficient

1. Edit notification
2. Remove title (Quality notification could not be saved )
3. Add title (Quality notification could still not be saved )

Part is not removed from available parts

Input validation hung

• Entering a text in notification form blocks the application for a period for more than 5 seconds

[ds-mmaul]

Testing

• User: Admin has no permission to execute action "Edit notification" in all views
• User: Supervisor has permission to execute action "Edit notification" in all views
• User: User has permission to execute action "Edit notification" in all views
• User: Supervisor : Paginate to second page > Edit notification > Back : Page 2 is displayed with edit part

--> Not seen as Feedback to implement

@mkanal implemented your feedback in (catenax-ng#1167). the last two points (performance & removal of selected parts) will be considered in the issue #834