Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Try Again button is not working #1009

Closed
ds-crehm opened this issue May 24, 2024 · 2 comments · Fixed by #1136 or #1174
Closed

[BUG] Try Again button is not working #1009

ds-crehm opened this issue May 24, 2024 · 2 comments · Fixed by #1136 or #1174
Assignees
@mkanal
Labels
bug Something isn't working frontend Frontend related Issues

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented May 24, 2024 •
edited
Loading

Description

Happened on E2E-A during testing of #1008:
Clicking the Try Again button in the pop-up error message that appears after the user unsuccessfully sent a notification does nothing.

Current behaviour

After approving a notification, which can not be sent, an error pop-up appears. Clicking on the "Try Again" button within that error pop-up does nothing.
Image
Clicking on it -> Nothing happens (no logs in backend or frontend)

Expected behavior

After clicking Try Again, the approval modal appears again and I can approve the notification again:
Image

Steps to reproduce the Bug

  1. Create notification that cannot be sent (for example wrong receiver BPN) Image
  2. Approve notification
  3. Wait for error pop-up
  4. Click on Try Again
@ds-crehm ds-crehm added this to Trace-X May 24, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X May 24, 2024
@ds-crehm ds-crehm changed the title [BUG] Try Again button after unsuccessfully sending a notification is not working [BUG] Try Again button is not working May 24, 2024
@ds-crehm ds-crehm added bug Something isn't working frontend Frontend related Issues labels May 24, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Jun 18, 2024
@mkanal mkanal moved this from backlog to next in Trace-X Jun 26, 2024
@ds-mmaul ds-mmaul moved this from next to wip in Trace-X Jun 28, 2024
@ds-mmaul ds-mmaul self-assigned this Jun 28, 2024
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Merged
2 tasks
ds-mmaul added a commit that referenced this issue Jul 2, 2024
@ds-mmaul
Merge branch 'main' into bug/#1009-try-again-button-fix
4d4de4f
ds-mmaul added a commit that referenced this issue Jul 2, 2024
@ds-mmaul
Merge remote-tracking branch 'eclipse/bug/#1009-try-again-button-fix'…
955068c 
… into bug/#1009-try-again-button-fix
ds-mmaul added a commit that referenced this issue Jul 3, 2024
@ds-mmaul
Merge branch 'main' into bug/#1009-try-again-button-fix
aa45088
ds-mmaul added a commit that referenced this issue Jul 3, 2024
@ds-mmaul
Merge remote-tracking branch 'refs/remotes/eclipse/main' into bug/#1009…
46aa6ff 
…-try-again-button-fix
ds-mmaul added a commit that referenced this issue Jul 3, 2024
@ds-mmaul
Merge remote-tracking branch 'eclipse/bug/#1009-try-again-button-fix'…
38824e8 
… into bug/#1009-try-again-button-fix
ds-mwesener added a commit that referenced this issue Jul 3, 2024
@ds-mwesener
Merge pull request #1136 from eclipse-tractusx/bug/#1009-try-again-bu…
12fefb5 
…tton-fix

Bug/#1009 try again button fix
@ds-mmaul ds-mmaul moved this from wip to test in Trace-X Jul 3, 2024
@ds-crehm
Copy link
Contributor Author

ds-crehm commented Jul 3, 2024 •
edited
Loading

Tested on E2E: Try again button works now. The approval modal doesn't reappear like before, but this seems to be even better since I don't see a point of having to reapprove.

Ready for review.

@ds-crehm ds-crehm reopened this Jul 3, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 3, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul and ds-crehm Jul 3, 2024
ds-mwesener added a commit that referenced this issue Jul 3, 2024
@ds-mwesener
Merge pull request #1156 from eclipse-tractusx/bug/#1009-try-again-bu…
82fd371 
…tton-fix

chore(contracts): 1005 change labelling
@github-actions github-actions bot mentioned this issue Jul 5, 2024
Merged
2 tasks
ds-mwesener added a commit that referenced this issue Jul 5, 2024
@ds-mwesener
Merge pull request #1174 from eclipse-tractusx/bug/#1009-try-again-bu…
28d8949 
…tton-fix

chore(notifications): 1009 change labelling
@mkanal mkanal moved this from review to done in Trace-X Jul 9, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 9, 2024

LGFM @mkanal PO acceptance in behalf of @jzbmw.

@mkanal mkanal reopened this Jul 9, 2024
@mkanal mkanal closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
bug Something isn't working frontend Frontend related Issues
Projects
Trace-X
Status: done
Milestone
No milestone
3 participants
@mkanal @ds-mmaul @ds-crehm