Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Edit notifications not working #1008

Closed
ds-crehm opened this issue May 24, 2024 · 1 comment
Closed

[BUG] Edit notifications not working #1008

ds-crehm opened this issue May 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ds-crehm
Copy link
Contributor

Description

Happened on E2E-A:
Sending a notification after it was edited is not possible.

Current behaviour

After editing a notification (regardless of what was changed), it cannot be sent anymore and "Created by Manufacturer" changes to the BPN and "Sent to Manufacturer" gets deleted (even when the user didn't change the BPN).

Expected behavior

Only the data changed by the user should be changed during the Edit notification process ("Created by Manufacturer" should never change - "Sent to Manufacturer" should only change according to the chosen BPN, if the user changed it). If the data is correct, the notification must be approvable and sent to the chosen BPN without issues.

Steps to reproduce the Bug

  1. Create notification Image
  2. View notification details Image
  3. Edit notification (in this case only the description was changed) Image
  4. Save notification
  5. View notification details Image
  6. Approve notification Image
@ds-crehm ds-crehm added this to Trace-X May 24, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X May 24, 2024
@ds-crehm ds-crehm added bug Something isn't working backend Backend related issues labels May 24, 2024
@mkanal mkanal removed the backend Backend related issues label Jun 21, 2024
@ds-crehm
Copy link
Contributor Author

This has changed and is addressed in ticket #1122
Will close this ticket.

@ds-crehm ds-crehm moved this from inbox to done in Trace-X Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: done
Development

No branches or pull requests

2 participants