Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[BUG] Editing "sendTo" BPN changes "createdBy" BPN #1122

Closed
ds-crehm opened this issue Jun 27, 2024 · 3 comments · Fixed by #1327
Closed

🐞[BUG] Editing "sendTo" BPN changes "createdBy" BPN #1122

ds-crehm opened this issue Jun 27, 2024 · 3 comments · Fixed by #1327
Assignees
Labels
backend Backend related issues bug Something isn't working

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented Jun 27, 2024

Description

When editing a notification and changing the receiver BPN, that data remains unchanged while the "createdBy" BPN is set to the changed value. EDIT: CreatedBy BPN always changes regardless of what was edited, which means editing and then sending notifications is not possible currently.

Current behaviour

When I look at a notification:
Image
And I want to change the "Sent to BPN" value and go to the edit mode:
Image
And then save it, the "Sent to BPN" value stays the same, while the "Created by BPN" is changed:
Image

(In the backend, the "createdBy" value changes, while the "sendTo" value remains the same.)

Expected behavior

When I change the receiver BPN, I expect the "Sent to BPN" to be changed instead of the "Created by BPN". The "Created by BPN" must never be changed in the notification.

Additionally, the error pop-up message when approving this kind of notification should be more descriptive, so that the user knows what the problem is and that it's not possible to send notifications with a different senderBPN. Then he can close this notification and create a new one.

Steps to reproduce the Bug

  1. Create a notification
  2. Edit the notification and change the BPN value
  3. Go to detail view of the notification to view the changes
@ds-crehm ds-crehm added this to Trace-X Jun 27, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Jun 27, 2024
@ds-crehm ds-crehm added bug Something isn't working backend Backend related issues labels Jun 27, 2024
@ds-crehm ds-crehm changed the title [BUG] Editing "sendTo" BPN changes "createdBy" BPN 🐞[BUG] Editing "sendTo" BPN changes "createdBy" BPN Jul 23, 2024
@mkanal mkanal moved this from inbox to backlog in Trace-X Jul 23, 2024
@ds-crehm
Copy link
Contributor Author

Whenever I receive a notification the "createdBy" BPN is always my own, which is technically correct but it's confusing. Either it should be the one who initially created the notification or it could be renamed to "sentBy" and then have the correct BPN or it can be removed if it always contains the own BPN (then it has no use).

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Jul 29, 2024

With the PR: #1327, the expected behavior was verified on dev environment.
Step1: Created alert
grafik

Step2: change receiver BPN
grafik

Step3: see new receiver BPN
grafik

@ds-mwesener ds-mwesener moved this from backlog to wip in Trace-X Jul 30, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Jul 30, 2024
@ds-crehm
Copy link
Contributor Author

Tested successfully on E2E:
I create the following notification with a wrong BPN and I can't send it:
grafik

I edit the nontification to use the correct BPN:
grafik

Now I can send it:
grafik

Ready for review.

@ds-crehm ds-crehm reopened this Jul 30, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X Jul 30, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-lcapellino and ds-crehm Jul 30, 2024
@mkanal mkanal moved this from review to done in Trace-X Aug 6, 2024
@mkanal mkanal closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues bug Something isn't working
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants