-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞[BUG] Editing "sendTo" BPN changes "createdBy" BPN #1122
Comments
Whenever I receive a notification the "createdBy" BPN is always my own, which is technically correct but it's confusing. Either it should be the one who initially created the notification or it could be renamed to "sentBy" and then have the correct BPN or it can be removed if it always contains the own BPN (then it has no use). |
With the PR: #1327, the expected behavior was verified on dev environment. |
Description
When editing a notification and changing the receiver BPN, that data remains unchanged while the "createdBy" BPN is set to the changed value. EDIT: CreatedBy BPN always changes regardless of what was edited, which means editing and then sending notifications is not possible currently.
Current behaviour
When I look at a notification:
And I want to change the "Sent to BPN" value and go to the edit mode:
And then save it, the "Sent to BPN" value stays the same, while the "Created by BPN" is changed:
(In the backend, the "createdBy" value changes, while the "sendTo" value remains the same.)
Expected behavior
When I change the receiver BPN, I expect the "Sent to BPN" to be changed instead of the "Created by BPN". The "Created by BPN" must never be changed in the notification.
Additionally, the error pop-up message when approving this kind of notification should be more descriptive, so that the user knows what the problem is and that it's not possible to send notifications with a different senderBPN. Then he can close this notification and create a new one.
Steps to reproduce the Bug
The text was updated successfully, but these errors were encountered: