-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated data model io.catenax.vehicle.product_description to SAMM:2.0.0 #178
Updated data model io.catenax.vehicle.product_description to SAMM:2.0.0 #178
Conversation
- model updated to SAMM:2.0.0 - entities relinked - see readme.md for details
Modelling_Team |
@bs-jokri Please do a pre-MS2 check :-) Thank you |
License header updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the encoding issues
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
Fixed mentioned encoding issues
@bs-jokri I fixed the encoding - what's the problem with preferred name check? I didn't change anything here -> all preferred names are same like in semantic model version 2.0.0 |
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
@bs-jokri Could you complete MS2 checks? Thank you |
- Checked license header - Removed some typos
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
Updated copyright notice
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
Updated copyright section, set release date to today
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarks to change:
- Preferred names start all with upper case and do preferrably not use shortcuts.
- All sentences start with upper case, end with a dot and do preferrably not use shortcuts.
- some missing pieces
if you edit the preferred names watch out for: " no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)"
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are properly addressed, thus good to go
Updated some of the descriptions
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
#modeling_team |
Fix some typos
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
Fixed some issues Carolin mentioned
https://github.com/TorstenHirsch/sldt-semantic-models into Issue-176-Update-vehicle.product-description-to-3.0.0
Validation Report for io.catenax.vehicle.product_description/3.0.0/ProductDescription.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
PR [New Model]: Feature 163, List of Vehicle Product Discription needed for QAX and Catena-X release 3.2 #175
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)