-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model]: Feature 163, List of Vehicle Product Discription needed for QAX and Catena-X release 3.2 #175
Conversation
First draft of initial version: shell around Vehicle.ProductDescription:2.0.0
@bs-jokri PR für die Liste von Vehicle.ProductDescription:2.0.0 |
Initial version of the model with already integrated license header
Updated license information
did my tests with temporarily merging #178 to have the updated referenced model available |
Model can be MS2 approved under the condition that #178 is available |
add issue link, so the issue will be closed after the merge |
#modeling_team |
Validation Report for io.catenax.fleet.vehicles/1.0.0/Vehicles.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR creates a new semantic model, that allows to transfer multiple vehicle descriptions.
The new model references Vehicle.ProductDescription in version 3.0.0
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)