Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refactor): remove direct imports from mui #855

Merged
merged 5 commits into from
Jun 3, 2024
Merged

fix(refactor): remove direct imports from mui #855

merged 5 commits into from
Jun 3, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented May 31, 2024 •
edited
Loading

Description

remove importing of typography, dialog and circular progress from mui and use shared-components

Why

do not import unwanted properties from mui

Issue

#697

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review May 31, 2024 08:00
nidhigarg-bmw
nidhigarg-bmw approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

lavanya-bmw
lavanya-bmw approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojava-gk manojava-gk reopened this May 31, 2024
@manojava-gk manojava-gk marked this pull request as draft May 31, 2024 08:34
@manojava-gk manojava-gk changed the title fix(refactor): remove trans from mui fix(refactor): remove direct imports from mui Jun 1, 2024
nidhigarg-bmw
nidhigarg-bmw approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojava-gk manojava-gk requested a review from nidhigarg-bmw June 3, 2024 09:06
@manojava-gk manojava-gk marked this pull request as ready for review June 3, 2024 09:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit 992dd2e into eclipse-tractusx:dev Jun 3, 2024
8 checks passed
@oyo oyo deleted the fix/issues-697 branch June 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

@nidhigarg-bmw nidhigarg-bmw Awaiting requested review from nidhigarg-bmw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manojava-gk @oyo @nidhigarg-bmw @lavanya-bmw