Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of MUI component instead of shared component #697

Closed
oyo opened this issue Apr 10, 2024 · 2 comments
Closed

Use of MUI component instead of shared component #697

oyo opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@oyo
Copy link
Contributor

oyo commented Apr 10, 2024

Current Behavior

Some times code uses MUI components directly where better alternatives exist.

Expected Behavior

We created the Shared Components to simplify development and preconfigure MUI components for our style. They should be used whenever possible.

Steps To Reproduce

Example:
https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/components/overlays/AddMultipleUser/index.tsx#L25
Typography exists in the shared components

@oyo oyo added the bug Something isn't working label Apr 10, 2024
@oyo oyo added this to Portal Apr 10, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Apr 10, 2024
@jjeroch jjeroch moved this from NEW USER REQUEST to BACKLOG in Portal May 30, 2024
@jjeroch jjeroch added this to the Release 24.08 milestone May 30, 2024
@jjeroch
Copy link
Contributor

jjeroch commented May 30, 2024

@manojava-gk could you please verify this once and adjust the implementation where needed

@oyo
Copy link
Contributor Author

oyo commented Jun 4, 2024

@jjeroch this has been merged to dev because it's a fully backwards compatible pure technical change using our shared components instead of direct MUI imports.

@evegufy evegufy closed this as completed Jul 11, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants