Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc]: PCF Documentation update #44

Merged
merged 4 commits into from
Nov 28, 2023
Merged

[doc]: PCF Documentation update #44

merged 4 commits into from
Nov 28, 2023

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Nov 28, 2023 •
edited
Loading

Description

  • PCF Documentation update

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor Author

ajithsimons commented Nov 28, 2023 •
edited
Loading

Please Merge this PR after #43

@dvasunin Please review it.

@FaGru3n Please merge after review.

@ajithsimons ajithsimons mentioned this pull request Nov 28, 2023
Merged
2 tasks
@ajithsimons ajithsimons changed the title (doc): PCF Documentation update [doc]: PCF Documentation update Nov 28, 2023
dvasunin
dvasunin reviewed Nov 28, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
dvasunin
dvasunin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adityagajbhiye9
adityagajbhiye9 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dvasunin
dvasunin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FaGru3n
FaGru3n suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the docker file changes from our pr

Dockerfile Outdated Show resolved Hide resolved
@adityagajbhiye adityagajbhiye force-pushed the hotfix_3.2_with_pcf_part3 branch from f53f6c8 to aa44461 Compare November 28, 2023 13:50
@ajithsimons ajithsimons requested a review from FaGru3n November 28, 2023 13:56
adityagajbhiye9
adityagajbhiye9 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dvasunin
dvasunin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FaGru3n
FaGru3n approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n merged commit 8d3a9a0 into eclipse-tractusx:main Nov 28, 2023
6 checks passed
@FaGru3n FaGru3n deleted the hotfix_3.2_with_pcf_part3 branch November 28, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@FaGru3n FaGru3n FaGru3n approved these changes

@dvasunin dvasunin dvasunin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajithsimons @dvasunin @FaGru3n @adityagajbhiye9 @AjayRaturi123