Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Code refactor: File download from server and page layout #43

Merged
merged 18 commits into from
Nov 28, 2023

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Nov 28, 2023

Description

  • Download file functions code optimisations.
  • Page layout css fixes.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor Author

ajithsimons commented Nov 28, 2023

Please Merge this PR after #42

@dvasunin Please review it.

@FaGru3n Please merge after review.

@ajithsimons ajithsimons mentioned this pull request Nov 28, 2023
2 tasks
@ajithsimons ajithsimons changed the title (chore): Code refactor: File download from server and page layout [chore]: Code refactor: File download from server and page layout Nov 28, 2023
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n requested review from hzierer and FaGru3n November 28, 2023 13:34
@@ -2,6 +2,15 @@

New features, fixed bugs, known defects and other noteworthy changes to each release of the Simple Data Exchanger Frontend.

## [2.1.2] - non-released
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: don´t know why you add a new patch version for that i would assume i could be also done in the same non-released version

Copy link

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could not verify the content and the functionality

@FaGru3n FaGru3n merged commit 966632f into eclipse-tractusx:main Nov 28, 2023
4 checks passed
@FaGru3n FaGru3n deleted the hotfix_3.2_with_pcf_part2 branch November 28, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants