Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated values file #76

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: Updated values file #76

merged 2 commits into from
Sep 5, 2023

Conversation

adkumar1
Copy link
Contributor

@adkumar1 adkumar1 commented Sep 5, 2023 •
edited
Loading

SebastianBezold
SebastianBezold suggested changes Sep 5, 2023
View reviewed changes
charts/orchestrator/values-int.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to specify values, that are already present in the default values.yaml.
please only specify stuff that is actually overwritten or additionally defined.
This makes it clearer to others, which parts of the config are environment specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated files

SebastianBezold
SebastianBezold reviewed Sep 5, 2023
View reviewed changes
charts/orchestrator/values-int.yaml
containerSecurityContext:
enabled: false
auth:
username: "orchdbuser"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept this change, since it at least fixes the default values, but you need to remove the hardcoded passwords. either use a secure vault, or use the auto-generated passwords provided by the bitnami chart

@SebastianBezold SebastianBezold merged commit 7b1758a into eclipse-tractusx:main Sep 5, 2023
@SebastianBezold SebastianBezold deleted the qualitygate branch September 5, 2023 09:53
@SebastianBezold SebastianBezold mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianBezold SebastianBezold SebastianBezold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Chart values contain environment specific settings
2 participants
@adkumar1 @SebastianBezold