Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Charts config log and timeout #25

Merged

Conversation

MajdT51
Copy link
Contributor

@MajdT51 MajdT51 commented Feb 23, 2023

After merging

@MajdT51 MajdT51 changed the title DRAFT: Charts config log and timeout Charts config log and timeout Feb 23, 2023
@MajdT51
Copy link
Contributor Author

MajdT51 commented Feb 23, 2023

@jpbu could you please review it? The other PR must be merged first to generate the images.

@MajdT51 MajdT51 mentioned this pull request Feb 23, 2023
Copy link
Contributor

@jpbu jpbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good from my side, one comment regarding the timeout values.

I would suggest to also include the genesis url change in this pull request, it looks like https://idu.cloudcompass.ca/ still has problems.

charts/managed-identity-wallets/values-int.yaml Outdated Show resolved Hide resolved
@MajdT51 MajdT51 requested a review from jpbu February 23, 2023 17:00
Copy link
Contributor

@jpbu jpbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, also verified the new genesis url for INT/IDUnion testnet locally and it worked.

@MajdT51
Copy link
Contributor Author

MajdT51 commented Feb 24, 2023

Hello @carslen, could you please merge this? it is related to the other already merged PR (#24) and just update the charts.
Thanks

@@ -78,7 +98,7 @@ acapy:
# The configuration of the AcaPy endorser instance
endorser:
# -- The url of the used Indy ledger
ledgerUrl: "https://idu.cloudcompass.ca"
ledgerUrl: "https://raw.githubusercontent.com/catenax-ng/product-core-schemas/main/genesis"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this URL make sense for the default config? Would it also be a possibility to package that in some kind of nginx docker image, that you can then deploy with your app if i.e. 'localLedger=true' is set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. We are not using a local ledger, we just copied the genesis file from the scanner of the idunion test ledger, because it has a temporary certificate problem. I changed the values for now and in the future, this will be changed and the genesis files would be probably given directly to AcaPy instances instead of loading them from external urls.

@SebastianBezold SebastianBezold merged commit e0e0a6b into eclipse-tractusx:main Feb 24, 2023
@SebastianBezold SebastianBezold deleted the charts-config-log-and-timeout branch February 24, 2023 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants