-
Notifications
You must be signed in to change notification settings - Fork 5
Charts config log and timeout #25
Charts config log and timeout #25
Conversation
@jpbu could you please review it? The other PR must be merged first to generate the images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good from my side, one comment regarding the timeout values.
I would suggest to also include the genesis url change in this pull request, it looks like https://idu.cloudcompass.ca/ still has problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, also verified the new genesis url for INT/IDUnion testnet locally and it worked.
@@ -78,7 +98,7 @@ acapy: | |||
# The configuration of the AcaPy endorser instance | |||
endorser: | |||
# -- The url of the used Indy ledger | |||
ledgerUrl: "https://idu.cloudcompass.ca" | |||
ledgerUrl: "https://raw.githubusercontent.com/catenax-ng/product-core-schemas/main/genesis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this URL make sense for the default config? Would it also be a possibility to package that in some kind of nginx docker image, that you can then deploy with your app if i.e. 'localLedger=true' is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. We are not using a local ledger, we just copied the genesis file from the scanner of the idunion test ledger, because it has a temporary certificate problem. I changed the values for now and in the future, this will be changed and the genesis files would be probably given directly to AcaPy instances instead of loading them from external urls.
After merging