Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Config log and timeout #24

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Config log and timeout #24

merged 3 commits into from
Feb 24, 2023

Conversation

MajdT51
Copy link
Contributor

@MajdT51 MajdT51 commented Feb 22, 2023

Charts and deployments will be updated in another PR.

@MajdT51 MajdT51 mentioned this pull request Feb 23, 2023
Merged
@MajdT51 MajdT51 changed the title DRAFT: Config log and timeout Config log and timeout Feb 23, 2023
@MajdT51
Copy link
Contributor Author

MajdT51 commented Feb 23, 2023

@jpbu could you review this, please?

jpbu
jpbu reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jpbu jpbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good except one comment regarding the release version.

Logging seems appropriate now with the settings from example env, though I would set LOG_LEVEL_EXPOSED to OFF on INT.

gradle.properties Outdated Show resolved Hide resolved
@MajdT51
Copy link
Contributor Author

MajdT51 commented Feb 23, 2023 •
edited
Loading

Hello @carslen could you please review and merge this branch?

The updated charts are in another pull request -> #25

@SebastianBezold
Copy link
Contributor

Hi @MajdT51,
changes look good to me. Would you need a new tag on main aswell? v3.3.2?

@SebastianBezold SebastianBezold merged commit 3b011e7 into eclipse-tractusx:main Feb 24, 2023
@SebastianBezold SebastianBezold deleted the config-log-and-timeout branch February 24, 2023 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpbu jpbu jpbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MajdT51 @SebastianBezold @jpbu