chore: update spring boot to version 3.3.1 #784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed CustomUriTagProvider to CustomKeyValueProvider since the Tag class is no longer used by the new DefaultClientRequestObservationConvention class - Accordingly, CustomKeyValueProvider does not have a method that returns a list of Tag, but KeyValues - Temporary workaround: due to the changes mentioned at https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x?secureweb=Teams#parameter-name-retention, old Java code now needs to be compiled using the -parameters flag to work - The DefaultAcceptedPoliciesConfig.AcceptedPolicy class now has a NoArgsConstructor because otherwise it currently won't bind values in application.yaml - Validation of UUID arguments size in IrsController and BatchController has been removed since it's superfluous and causing crashes
- Starting with Spring Framework 6.1 (Spring Boot 3.3 brings version 6.1.8), Spring's LocalVariableTableParameterNameDiscoverer can no longer be used to discover parameter names, see https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention. This required some changes in the code: - Methods in the rest controller classes now explicitly include parameter names in the @PathVariable and @RequestParameter annotations, otherwise the parameters are not recognized. - When using the @Cacheable annotation (e.g. in SemanticsHubFacade), it is no longer possible to use a SpEl expression like "#urn" to specify the caching key. Instead, the code now needs a SpEl-Expression like "#p0", see https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/cache/annotation/Cacheable.html#key().
…troller changes made due to spring boot update
|
Dependencies to vet: maven/mavencentral/org.apache.logging.log4j/log4j-slf4j2-impl/2.23.1 and maven/mavencentral/org.springframework.security/spring-security-test/6.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #380.
The
CustomUriTagProviderclass has been renamed toCustomKeyValueProvider. This is due to the fact that Spring 3.2 dropped some classes and the code now uses their replacement. This replacement class no longer uses theTagclass, but theKeyValueandKeyValuesclasses.Starting with Spring Framework 6.1 (Spring Boot 3.3.1 brings version 6.1.10), Spring's
LocalVariableTableParameterNameDiscoverercan no longer be used to discover parameter names, see https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention. This required some changes in the code:Methods in the rest controller classes now explicitly include parameter names in the
@PathVariableand@RequestParameterannotations, otherwise the parameters are not recognized. In the methods that were changed, the (apparently generally superfluous) validation of passed UUIDs using@Sizehas been removed since it caused errors. The OpenAPI spec has been adapted accordingly. An integration test has been added inBatchControllerTestto verify that this removal does not allow requests with malformed UUIDs.When using the
@Cacheableannotation (e.g. inSemanticsHubFacade), it is no longer possible to use a SpEl expression like"#urn"to specify the caching key. Instead, the code now needs a SpEl-Expression like"#p0", see https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/cache/annotation/Cacheable.html#key().Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: