Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Spring Boot 3.1.x to >= 3.2.x #380

Open
dsmf opened this issue Jan 22, 2024 · 0 comments
Open

Update from Spring Boot 3.1.x to >= 3.2.x #380

dsmf opened this issue Jan 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dsmf
Copy link
Contributor

dsmf commented Jan 22, 2024

As a product
I want to update Spring Boot version to >= 3.2.x
so that IRS works with the current Spring Boot version.

Links

Hints / Details

  • https://github.com/spring-projects/spring-boot/releases

  • Updating to Spring Boot 3.2.x involves more than just updating the version number because Spring 3.2 dropped some classes:

    • RestTemplateExchangeTags
    • RestTemplateExchangeTagsProvider (in favor of ClientRequestObservationConvention
    • We use these classes in module irs-api o.e.t.irs.util.CustomUriTagProvider for providing a custom prometheus tag configuration for the request buckets because the default configuration includes the query string in the URI tag which leads to lots of metric entries for each different call.
  • Maybe adding a new (integration) test is necessary, because there does not seem to be any test that would verify our custom Prometheus configuration yet.

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  1. Update to Spring Boot version to 3.2.x
  2. Find and implement solution for dropped classes (and prove in some way that the custom prometheus configuration is still working).

Out of Scope

@dsmf dsmf added this to IRS Jan 22, 2024
@dsmf dsmf converted this from a draft issue Jan 22, 2024
@dsmf dsmf changed the title Update from Spring Boot 3.1.6 to 3.2.1 Update from Spring Boot 3.1.6 to 3.2.x Jan 22, 2024
@mkanal mkanal moved this from backlog to inbox in IRS Jan 23, 2024
@dsmf dsmf changed the title Update from Spring Boot 3.1.6 to 3.2.x Update from Spring Boot 3.1.x to 3.2.x Jan 26, 2024
@jzbmw jzbmw added the enhancement New feature or request label Feb 15, 2024
@mkanal mkanal changed the title Update from Spring Boot 3.1.x to 3.2.x Update from Spring Boot 3.1.x to 3.2.3 Feb 19, 2024
@dsmf dsmf changed the title Update from Spring Boot 3.1.x to 3.2.3 Update from Spring Boot 3.1.x to 3.2.x Mar 22, 2024
@dsmf dsmf changed the title Update from Spring Boot 3.1.x to 3.2.x Update from Spring Boot 3.1.x to >= 3.2.x Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: inbox
Development

No branches or pull requests

2 participants