Introducing ESS-Batch, better configuration, Spring Boot update #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chController.java Co-authored-by: Jaro Hartmann <[email protected]>
…chController.java Co-authored-by: Jaro Hartmann <[email protected]>
…gisterBpnInvestigationBatchOrder.java Co-authored-by: Jaro Hartmann <[email protected]>
…e/TRI-1664-new-batch-api-endpoint
… cutting concepts
…i-endpoint feat(impl):[TRI-1664] new batch api endpoints impl
…g-boot feat(impl):[TRI-1661] update spring boot version to newest
…laim-configurable Feature/tri 1611 make oauth claim configurable
…entation feat(docs):[TRI-1654] Add section in building block view for subproto…
…lity is in every version
…does not apply to Java deployments that load and run only trusted code. This is not exploitable in IRS.
Chore/update dependencies
ds-ext-kmassalski
approved these changes
Oct 12, 2023
mkanal
reviewed
Oct 12, 2023
| @@ -111,7 +115,7 @@ public class SecurityConfiguration { | |||
|
|
|||
| httpSecurity.oauth2ResourceServer(oauth2ResourceServer -> | |||
| oauth2ResourceServer.jwt(jwt -> | |||
| jwt.jwtAuthenticationConverter(new JwtAuthenticationConverter()))) | |||
| jwt.jwtAuthenticationConverter(jwtAuthenticationConverter))) | |||
There was a problem hiding this comment.
Why is this not injected directly in converter? Is JwtAuthenticationConverter a Bean?
There was a problem hiding this comment.
JwtAuthenticationConverter is a Bean
irs-api/src/main/java/org/eclipse/tractusx/irs/controllers/BatchController.java
Show resolved
Hide resolved
irs-api/src/main/java/org/eclipse/tractusx/irs/connector/job/MultiTransferJob.java
Show resolved
Hide resolved
irs-api/src/main/java/org/eclipse/tractusx/irs/ess/service/BpnInvestigationJob.java
Show resolved
Hide resolved
mkanal
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Changed
oauth.resourceClaim,oauth.irsNamespace,oauth.roles.Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: