Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(impl):[TRI-1664] new batch api endpoints impl #561

Merged
merged 20 commits into from
Oct 9, 2023

Conversation

ds-ext-kmassalski
Copy link

No description provided.

@ds-ext-kmassalski ds-ext-kmassalski marked this pull request as ready for review October 3, 2023 14:25
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested and a couple of questions.
Tests are failing and Sonar found some issues.

ds-ext-kmassalski and others added 3 commits October 4, 2023 12:13
@ds-ext-kmassalski
Copy link
Author

Duplications on RegisterBpnInvestigationBatchOrder class is expected here - own model

Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.6% 81.6% Coverage
9.8% 9.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ds-ext-kmassalski ds-ext-kmassalski merged commit 15367fa into main Oct 9, 2023
@ds-ext-kmassalski ds-ext-kmassalski deleted the feature/TRI-1664-new-batch-api-endpoint branch October 9, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants