Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json schema validation results are wrong with newest jsonschemafriend library #522

Closed
ds-ext-kmassalski opened this issue Apr 8, 2024 · 4 comments
Closed

Json schema validation results are wrong with newest jsonschemafriend library #522

ds-ext-kmassalski opened this issue Apr 8, 2024 · 4 comments
Assignees
@ds-ext-kmassalski
Labels
bug Something isn't working R24.5 release-hot-fix pbi is relevant for current release and for hotfix path

Comments

@ds-ext-kmassalski
Copy link
Contributor

ds-ext-kmassalski commented Apr 8, 2024 •
edited
Loading

Description

Current behaviour

Validation of json-schema passed successfully for SLBAB Payload #2.0.0 and SLBAB json-schema #3.0.0

Expected behavior

SLBAB Payload in #2.0.0 should not pass validation with SLBAB json-schema #3.0.0 (quantity object is different)

Steps to reproduce the Bug

Check prepared unit test in: catenax-ng#852
Currently test is disabled, but should be enabled in the end.
@github-project-automation github-project-automation bot moved this to inbox in IRS Apr 8, 2024
@ds-jhartmann ds-jhartmann added the bug Something isn't working label Apr 8, 2024
@ds-ext-kmassalski ds-ext-kmassalski mentioned this issue Apr 9, 2024
Closed
7 tasks
@jzbmw jzbmw moved this from inbox to backlog in IRS Apr 12, 2024
@jzbmw jzbmw moved this from backlog to next in IRS Apr 16, 2024
@ds-jhartmann
Copy link
Contributor

ds-jhartmann commented Apr 16, 2024 •
edited
Loading

Planning 2:

  • the lib we use right now does not seem to work. We need to switch to a different one
  • lib needs to be open source -> check IP tool, if a manual approval is required and create IP lab tickets (contact @ds-jhartmann )

@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Apr 16, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Apr 16, 2024
@dsmf
Copy link
Contributor

dsmf commented Apr 18, 2024

Pull Request: catenax-ng#881

@dsmf dsmf mentioned this issue Apr 18, 2024
Merged
@ds-jhartmann ds-jhartmann mentioned this issue Apr 19, 2024
Merged
2 tasks
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to test in IRS Apr 19, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 19, 2024
@ds-ext-kmassalski
feat(impl):[#522] change json schema lib
951942e
ds-jhartmann pushed a commit that referenced this issue Apr 19, 2024
@ds-ext-kmassalski
Merge pull request #881 from catenax-ng/feat/522-change-json-schema-v…
9a0295a 
…alidation-lib

feat(impl):[#522] change json schema lib
ds-jhartmann added a commit that referenced this issue Apr 19, 2024
@ds-jhartmann
Merge pull request #550 from catenax-ng/main
144a810 
#522 Replace JSON Schema library
@mkanal
Copy link
Contributor

mkanal commented May 2, 2024

@dsmf @ds-jhartmann @ds-kgassner
INT Tests https://jira.catena-x.net/browse/TRI-767 https://jira.catena-x.net/browse/TRI-1913 https://jira.catena-x.net/browse/TRI-1914 https://jira.catena-x.net/browse/TRI-704 must be executed successful then this is done.

ds-jhartmann pushed a commit that referenced this issue May 2, 2024
@ds-ext-kmassalski
feat(impl):[#522] changelog log
cfcfcd8
ds-jhartmann added a commit that referenced this issue May 2, 2024
@ds-jhartmann
Merge pull request #900 from catenax-ng/feat/522-add-changelog
815bd72 
feat(impl):[#522] changelog log
@mkanal mkanal moved this from test to review in IRS May 13, 2024
@mkanal
Copy link
Contributor

mkanal commented May 13, 2024 •
edited
Loading

PO acceptance in behalf of @jzbmw. TRI-767 has the evidence.
image

@mkanal mkanal added R24.5 release-hot-fix pbi is relevant for current release and for hotfix path labels May 13, 2024
@mkanal mkanal moved this from review to done in IRS May 13, 2024
@mkanal mkanal closed this as completed May 13, 2024
ds-jhartmann added a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
@ds-jhartmann
Merge pull request eclipse-tractusx#522 from catenax-ng/chore/prepare…
65d6eb9 
…-release-3.4.0

chore(changelog): Prepare release 3.4.0
poojapatel23 added a commit to poojapatel23/item-relationship-service that referenced this issue Jul 5, 2024
@poojapatel23
IRS-739_add_value_for_submodel_url_for_IRS_version_4.5.2
6ab3780 
feat(impl):[eclipse-tractusx#522] change json schema lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-ext-kmassalski ds-ext-kmassalski

Labels
bug Something isn't working R24.5 release-hot-fix pbi is relevant for current release and for hotfix path
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dsmf @ds-jhartmann @mkanal @ds-ext-kmassalski