Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testdata set with Industry Core 2.0.0 compatibility #488

Closed
7 tasks done
mkanal opened this issue Mar 15, 2024 · 9 comments
Closed
7 tasks done

Update Testdata set with Industry Core 2.0.0 compatibility #488

mkanal opened this issue Mar 15, 2024 · 9 comments
Assignees
Labels
spill_over Issues which are not finished yet testing all testing related topics

Comments

@mkanal
Copy link
Contributor

mkanal commented Mar 15, 2024

As team
I want update to the latest test data set
so that we are up-to-date

Link

Hints / Details

  • https://jira.catena-x.net/browse/TDG-43

  • We already know that currently the tavern tests are failing regarding the SLBAB 3.0.0

  • Renaming will be clarified until 20th of march Replacing of Aspects

    • SerialPart --> PartInstance
    • PartAsPlaned -> PartType

SingleLevelBomAsBuilt version 3.0.0

 {
  "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
  "childItems" : [ {
    "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
    "quantity" : {
      "quantityNumber" : 2.5,            <<<<
      "measurementUnit" : "unit:litre"    <<<<
    },
    "hasAlternatives" : true,
    "createdOn" : "2022-02-03T14:48:54.709Z",
    "businessPartner" : "BPNL50096894aNXY",
    "lastModifiedOn" : "2022-02-03T14:48:54.709Z"
  } ]
}

SingleLevelBomAsBuil version 3.0.0

{
  "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
  "childItems" : [ {
    "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
    "quantity" : {
      "value" : 20.0,      <<<<
      "unit" : "unit:piece" <<<<
    },
    "hasAlternatives" : false,
    "createdOn" : "2022-02-03T14:48:54.709Z",
    "businessPartner" : "BPNL50096894aNXY",
    "lastModifiedOn" : "2022-02-03T14:48:54.709Z"
  } ]
}

Acceptance Criteria

Out of Scope

  • ...
@mkanal mkanal added this to IRS Mar 15, 2024
@mkanal mkanal converted this from a draft issue Mar 15, 2024
@mkanal mkanal removed the status in IRS Mar 15, 2024
@mkanal mkanal moved this to inbox in IRS Mar 15, 2024
@jzbmw jzbmw added the testing all testing related topics label Mar 18, 2024
@jzbmw jzbmw moved this from inbox to backlog in IRS Mar 18, 2024
@mkanal mkanal moved this from backlog to next in IRS Mar 19, 2024
@ds-jhartmann
Copy link
Contributor

Planning 2:

  • prepare a reduced set of testdata 1.7.0
  • change SingleLevelBomAsBuilt from 2.0.0 to 3.0.0
  • upload to DEV

@ds-jhartmann
Copy link
Contributor

@jzbmw According to #439, the tavern tests are supposed to be updated with this issue. We did not account for that in the refinement or planning.

Can we clarify how to deal with this in the next daily?

@dsmf
Copy link
Contributor

dsmf commented Mar 22, 2024

blocks #357

@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Mar 25, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Mar 27, 2024
@jzbmw jzbmw added the spill_over Issues which are not finished yet label Apr 2, 2024
ds-mwesener pushed a commit that referenced this issue Apr 3, 2024
ds-mwesener pushed a commit that referenced this issue Apr 3, 2024
ds-mwesener pushed a commit that referenced this issue Apr 3, 2024
ds-mwesener pushed a commit that referenced this issue Apr 3, 2024
ds-mwesener added a commit that referenced this issue Apr 3, 2024
feature: #488, #359, support SingleLevelBomAsBuilt v3.0.0, support Asset Administration Shell v3.1
@ds-ext-kmassalski
Copy link
Contributor

ds-ext-kmassalski commented Apr 4, 2024

1.7.0 is uploaded to DEV and Job can be registered:

{
	"aspects": [
		"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
		"urn:samm:io.catenax.serial_part:3.0.0#SerialPart"
	],
	"bomLifecycle": "asBuilt",
	"collectAspects": true,
	"lookupBPNs": false,
	"direction": "downward",
	"depth": 10,
	"key": {
		"globalAssetId": "urn:uuid:4235f1cf-d303-4b79-bdb1-7a31526bbabd",
		"bpn": "BPNL00000001CRHK"
	}
}

Job id: acb6a8c4-a7b5-4ce5-adea-81db30acc9da

Tavern tests will be fixed in scope of:
#503

@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to test in IRS Apr 4, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 5, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 5, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Apr 5, 2024

1.7.0 is uploaded to DEV and Job can be registered:

{
	"aspects": [
		"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
		"urn:samm:io.catenax.serial_part:3.0.0#SerialPart"
	],
	"bomLifecycle": "asBuilt",
	"collectAspects": true,
	"lookupBPNs": false,
	"direction": "downward",
	"depth": 10,
	"key": {
		"globalAssetId": "urn:uuid:4235f1cf-d303-4b79-bdb1-7a31526bbabd",
		"bpn": "BPNL00000001CRHK"
	}
}

Job id: acb6a8c4-a7b5-4ce5-adea-81db30acc9da

Tavern tests will be fixed in scope of: #503

BPNL00000001CRHK is incorrect -correct is BPNL00000003CSGV This test might not work.

@mkanal
Copy link
Contributor Author

mkanal commented Apr 5, 2024

Test Outcome:

Please rework @ds-ext-kmassalski

@mkanal mkanal moved this from test to wip in IRS Apr 5, 2024
@ds-ext-kmassalski
Copy link
Contributor

@mkanal

Yesterday I uploaded newest datasets:
https://github.com/catenax-ng/tx-item-relationship-service/blob/main/local/testing/testdata/CX_Testdata_v1.7.0_PartInstance-reduced.json

Example shell: urn:uuid:f719e96e-2d7a-4d25-b351-7ad81db4f12a + BPNL00000003AYRE

{
	"aspects": [
		"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt"
	],
	"bomLifecycle": "asBuilt",
	"collectAspects": true,
	"lookupBPNs": true,
	"direction": "downward",
	"depth": 10,
	"key": {
		"globalAssetId": "urn:uuid:f719e96e-2d7a-4d25-b351-7ad81db4f12a",
		"bpn": "BPNL00000003AYRE"
	}
}

Job ID: dcfde6fa-7653-40ed-9e9b-3cf31ec0cdde

Insomnia DEV env updated here:
https://github.com/catenax-ng/tx-item-relationship-service/pull/856/files

@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to test in IRS Apr 9, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Apr 9, 2024

{
"aspects": [
"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
"urn:samm:io.catenax.serial_part:3.0.0#SerialPart",
"urn:samm:io.catenax.just_in_sequence_part:3.0.0#JustInSequencePart",
"urn:samm:io.catenax.batch:3.0.0#Batch"
],
"key": {
"globalAssetId": "{% prompt 'Global Asset ID', 'Please provide 'Global-Asset-ID' or use default', _.GLOBAL_ASSET_ID, '', false, true %}",
"bpn": "{% prompt 'bpn', '', _.BPN, '', false, true %}"
},
"collectAspects": true
}

image

{
"aspects": [
"urn:samm:io.catenax.serial_part:3.0.0#SerialPart",
"urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
"urn:samm:io.catenax.batch:3.0.0#Batch",
"urn:samm:io.catenax.just_in_sequence_part:3.0.0#JustInSequencePart",
"urn:bamm:io.catenax.battery.product_description:1.0.1#ProductDescription",
"urn:bamm:io.catenax.material_for_recycling:1.1.0#MaterialForRecycling",
"urn:bamm:io.catenax.traction_battery_code:1.0.0#TractionBatteryCode",
"urn:bamm:io.catenax.part_as_planned:1.0.1#PartAsPlanned"
],
"key": {
"globalAssetId": "{% prompt 'Global Asset ID', 'Please provide 'Global-Asset-ID' or use default', _.GLOBAL_ASSET_ID, '', false, true %}",
"bpn": "{% prompt 'bpn', '', _.BPN, '', false, true %}"
},
"collectAspects": true,
"lookupBPNs": true
}

@mkanal
Copy link
Contributor Author

mkanal commented Apr 9, 2024

@jzbmw Retesting was successful works as indented. Kindly ask for PO acceptance.

@mkanal mkanal moved this from test to review in IRS Apr 9, 2024
@dsmf dsmf mentioned this issue Apr 10, 2024
2 tasks
@jzbmw jzbmw closed this as completed Apr 15, 2024
@jzbmw jzbmw moved this from review to done in IRS Apr 15, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 15, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 15, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 15, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 15, 2024
ds-jhartmann pushed a commit that referenced this issue Apr 15, 2024
feat(impl):[#488] Test that shoul pass, but currently is failing because library
ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
…569-container-scan-laster-image-in-docker-hub

feat(impl):[TRI-1569] container scan last image in docker hub
ds-jhartmann pushed a commit to ds-jhartmann/item-relationship-service that referenced this issue Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spill_over Issues which are not finished yet testing all testing related topics
Projects
Status: done
Development

No branches or pull requests

5 participants