Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide auto. Versioning of API and publish API to SwaggerHub #418

Closed
3 tasks
mkanal opened this issue Feb 13, 2024 · 4 comments
Closed
3 tasks

Provide auto. Versioning of API and publish API to SwaggerHub #418

mkanal opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels
api api specific issues documentation Improvements or additions to documentation spill_over Issues which are not finished yet

Comments

@mkanal
Copy link
Contributor

mkanal commented Feb 13, 2024

As team,
I want to publish api on swaggerhub
so that the api documentation is available for external contributors

Link

Hints / Details

For APIs with reference implementation:

Please use (or adapt existing) automated workflows to publish on SwaggerHub. Maintain your openAPI.yaml and the publishing workflow in the repository of the reference implementation. Remove everything related to that from the website repo and only link to SwaggerHub in your KIT from now on.
We utilize a user provided by the Eclipse Foundation to publish on SwaggerHub.
Credentials for this user can be used through the eclipse-tractusx GitHub org secrets and can be utilized in automated workflows.
Pay special attention to the "swaggerHub" CLI commands.
The location where the openAPI file is maintained may vary. The BPDM example showcases how the application is initiated to download and publish the current file from that location.

  SWAGGERHUB_API_KEY: ${{ secrets.SWAGGERHUB_API_KEY }}
  SWAGGERHUB_USER: ${{ secrets.SWAGGERHUB_USER }}

Examples:
BPDM Certificate Management: https://github.com/eclipse-tractusx/bpdm-certificate-management/blob/main/.github/workflows/publish-swagger-hub.yaml
Digital Product Pass: https://github.com/eclipse-tractusx/digital-product-pass/blob/main/.github/workflows/publish-swagger-hub.yaml
Tractus-X EDC: https://github.com/eclipse-tractusx/tractusx-edc/blob/main/.github/workflows/publish-swaggerhub.yaml
If you have any questions, please use our “Tractus-X Office Hour” and prepare accordingly before merging.

Outcome / Acceptance Criteria

Outcome

Acceptance Criteria

@mkanal mkanal added this to IRS Feb 13, 2024
@mkanal mkanal converted this from a draft issue Feb 13, 2024
@mkanal mkanal moved this from backlog to inbox in IRS Feb 13, 2024
@jzbmw jzbmw added documentation Improvements or additions to documentation api api specific issues labels Feb 15, 2024
@jzbmw jzbmw changed the title Provide API on swaggerhub.com (eclipse-tractusx-bot) Provide API to SwaggerHub Feb 23, 2024
@mkanal mkanal moved this from inbox to backlog in IRS Feb 28, 2024
@mkanal mkanal changed the title Provide API to SwaggerHub Provide auto. Versioning of API and publish API to SwaggerHub Feb 28, 2024
@mkanal mkanal moved this from backlog to next in IRS Mar 5, 2024
@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Mar 11, 2024
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Mar 11, 2024
@ds-ext-kmassalski
Copy link
Contributor

PR:
catenax-ng#814

@jzbmw jzbmw moved this from wip to test in IRS Mar 18, 2024
ds-jhartmann pushed a commit that referenced this issue Mar 19, 2024
…sh-api-to-swaggerhub

feat(impl):[#418] publish api to swagger hub
@mkanal mkanal moved this from test to review in IRS Mar 19, 2024
@mkanal mkanal moved this from review to test in IRS Mar 19, 2024
@mkanal mkanal added the spill_over Issues which are not finished yet label Mar 19, 2024
@ds-ext-kmassalski
Copy link
Contributor

Blocked by:
eclipse-tractusx/sig-infra#455

@ds-jhartmann
Copy link
Contributor

If the Swagger Hub Issue is resolved, re-run the publishing step in https://github.com/eclipse-tractusx/item-relationship-service/actions/runs/8339631309
image
image

@mkanal
Copy link
Contributor Author

mkanal commented Mar 21, 2024

@jzbmw AC is not achievable create FU story to resolve this within GitHub pages #500 Ready for PO review

@mkanal mkanal moved this from test to review in IRS Mar 21, 2024
@jzbmw jzbmw moved this from review to done in IRS Apr 2, 2024
@jzbmw jzbmw closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api api specific issues documentation Improvements or additions to documentation spill_over Issues which are not finished yet
Projects
Status: done
Development

No branches or pull requests

4 participants