#6308: Close websocket channel when a language server connection is closed #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
commented
Jan 9, 2020
| @@ -54,3 +54,18 @@ export namespace MessagingService { | |||
| configure(service: MessagingService): void; | |||
| } | |||
| } | |||
|
|
|||
| export interface WebSocketConnection extends IConnection { | |||
There was a problem hiding this comment.
This might be moved to vscode-ws-jsonrpc later.
akosyakov
added
core
akosyakov
approved these changes
Jan 14, 2020
…losed Signed-off-by: Miro Spönemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6308.
How to test
Add the following line to
json-starter.tsWithout this fix, the JSON language server stops working after 5 seconds. With the fix, the server is restarted every 5 seconds.
Review checklist
Reminder for reviewers