This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Added IWebSocketConnection interface #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spoenemann it does not compile |
akosyakov
approved these changes
Jan 16, 2020
|
@akosyakov I upgraded to Typescript 3.5.3, that resolves the compile error. Fine with that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eclipse-theia/theia#6854 I introduced an extension of the IConnection interface and a
createfunction to add a property to an existing IConnection. It would be better to include support for such an extension directly in the library.This change adds generic extension support to
createConnectionand uses that increateWebSocketConnectionto include the IWebSocket in the created connection.