Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make plugin download sequential #11860

Merged
merged 1 commit into from
Nov 23, 2022
Merged

ci: make plugin download sequential #11860

merged 1 commit into from
Nov 23, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Nov 10, 2022 •
edited
Loading

What it does

The pull-request updates the download:plugins script to use sequential downloads as the new default (rather than parallel).

The changes include:

  • the default for download:plugins is now set to parallel=false (sequential)
  • the build step during CI is broken down into their respective parts (Install, Download Plugins and Build)
  • we no longer unnecessarily call download;plugins for MacOS and Windows as we do not run integration tests there

How to test

Errors related to download:plugins (429) should occur less during CI.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Nov 10, 2022
msujew
msujew reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also respect this change in the gitpod config:

yarn --network-timeout 100000 && yarn build:examples

to

yarn --network-timeout 100000 && yarn build:examples && yarn download:plugins --parallel=false

@vince-fugnitto
ci: make plugin download sequential
ea1eb17 
The commit updates our CI to run the `download:plugins` script
sequentially to improve rate limiting errors.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto force-pushed the vf/sequential-download-ci branch from bf581c1 to ea1eb17 Compare November 15, 2022 16:43
@vince-fugnitto vince-fugnitto added the theia-cli issues related to the theia-cli label Nov 15, 2022
@vince-fugnitto vince-fugnitto marked this pull request as ready for review November 22, 2022 13:12
msujew
msujew approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I believe we should get this change into master before the release.

@vince-fugnitto vince-fugnitto merged commit b58de21 into master Nov 23, 2022
@vince-fugnitto vince-fugnitto deleted the vf/sequential-download-ci branch November 23, 2022 22:27
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 23, 2022
@msujew msujew mentioned this pull request Dec 6, 2022
Merged
1 task
@vince-fugnitto vince-fugnitto mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
ci issues related to CI / tests theia-cli issues related to the theia-cli
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @msujew