Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: update parallel default for download:plugins script #11861

Closed
vince-fugnitto opened this issue Nov 10, 2022 · 1 comment
Closed

cli: update parallel default for download:plugins script #11861

vince-fugnitto opened this issue Nov 10, 2022 · 1 comment
Labels
builtins Issues related to VS Code builtin extensions ci issues related to CI / tests theia-cli issues related to the theia-cli

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The download:plugins script currently download and resolves extensions (packs + depedencies) in parallel, but this may cause issues with how open-vsx recently implemented rate limiting.

We should ultimately update both our downloading and @theia/vsx-registry to respect the limit, but a good first step is improve the situation when downloading during CI and locally by performing sequential downloads. This should fix the occasional 429 errors we experience.

@vince-fugnitto vince-fugnitto added ci issues related to CI / tests theia-cli issues related to the theia-cli builtins Issues related to VS Code builtin extensions labels Nov 10, 2022
@vince-fugnitto
Copy link
Member Author

We introduced the sequential download by default #11860 and updated back to parallel with #11962 when we introduced client side rate limiting. I believe the issue can be closed, and downstream apps can always update the option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions ci issues related to CI / tests theia-cli issues related to the theia-cli
Projects
None yet
Development

No branches or pull requests

1 participant