Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade socket.io #11819

Merged
merged 1 commit into from
Oct 31, 2022
Merged

deps: upgrade socket.io #11819

merged 1 commit into from
Oct 31, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-requst upgrades socket.io to fix a known critical vulnerability with socket.io-parser.

How to test

  • CI should pass successfully.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit upgrades `socket.io` to fix a known critical vulnerability
with `socket.io-parser`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added security issues related to security dependencies pull requests that update a dependency file labels Oct 28, 2022
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince!

@vince-fugnitto vince-fugnitto merged commit 4ae2a68 into master Oct 31, 2022
@vince-fugnitto vince-fugnitto deleted the vf/socket.io-parser branch October 31, 2022 16:37
@github-actions github-actions bot added this to the 1.32.0 milestone Oct 31, 2022
vince-fugnitto added a commit that referenced this pull request Nov 1, 2022
The commit upgrades `socket.io` to fix a known critical vulnerability with `socket.io-parser`.

CVE: https://security.snyk.io/vuln/SNYK-JS-SOCKETIOPARSER-3091012

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this pull request Nov 9, 2022
The commit upgrades `socket.io` to fix a known critical vulnerability with `socket.io-parser`.

CVE: https://security.snyk.io/vuln/SNYK-JS-SOCKETIOPARSER-3091012

Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants