Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theia 1.31.1 #236

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Theia 1.31.1 #236

merged 1 commit into from
Nov 3, 2022

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Oct 28, 2022 •
edited
Loading

What it does

  • Theia 1.31.1 + upgraded dependencies
  • github workflow files updated to use node 14.x

How to test

Build Blueprint and check if everything is still working

Review checklist

Reminder for reviewers

@marcdumais-work
Copy link
Contributor

Hi @jfaltermeier,

Vince is fixing a pretty bad runtime vulnerability in the main repo: eclipse-theia/theia#11819

We are not sure yet if this warrants a 1.31.1 release or if we let adopters use a resolution to side-step the problem. Maybe you could quickly do the later in this PR?

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Oct 31, 2022 •
edited
Loading

[...] a pretty bad runtime vulnerability

Link: https://www.npmjs.com/advisories/1084823

@vince-fugnitto
Copy link
Member

@jfaltermeier I performed a patch release v1.31.1 to fix the known CVE. It would probably be best to upgrade to that version.

@jfaltermeier
Copy link
Contributor Author

@jfaltermeier I performed a patch release v1.31.1 to fix the known CVE. It would probably be best to upgrade to that version.

Thanks, will do

@jfaltermeier jfaltermeier changed the title Theia 1.31.0 Theia 1.31.1 Nov 3, 2022
@JonasHelming
Copy link
Contributor

@jfaltermeier Why are all builds failing?

@jfaltermeier jfaltermeier force-pushed the jf/1.31.0 branch 2 times, most recently from a82bff8 to 4eed020 Compare November 3, 2022 10:11
@jfaltermeier
Copy link
Contributor Author

jfaltermeier commented Nov 3, 2022 •
edited
Loading

@jfaltermeier Why are all builds failing?

Initially because the github workflows were still using node 12.
I have to check why the windows build does not work with node 14 now. Also sometimes we get failure because open-vsx has too many request and gives 429 codes.
I will rerequest the review when this is working.

@jfaltermeier
Theia 1.31.1
6df48fa 
+ upgrade dependencies
* Update workflow files to node 14
* use python 3.10.8
@jfaltermeier
Copy link
Contributor Author

@JonasHelming Besides the open-vsx issues the problem with windows was the python version. Python 3.11.0 does not seem to work, so I pinned the version to 3.10.8. Builds are green now.

@jfaltermeier jfaltermeier merged commit f3fcad9 into master Nov 3, 2022
@jfaltermeier jfaltermeier deleted the jf/1.31.0 branch November 3, 2022 13:45
@jfaltermeier jfaltermeier mentioned this pull request Jul 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasHelming JonasHelming JonasHelming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfaltermeier @marcdumais-work @vince-fugnitto @JonasHelming