Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligns icons of alerts and notifications to the text #10078

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

msujew
Copy link
Member

@msujew msujew commented Sep 10, 2021

What it does

Closes #10066

Aligns the icons to the text and vscode's styling.

vscode notifications:

image

Theia's notifications:

image

Alert messages:

image

How to test

  1. Delete all plugins/open a folder without a git repository
  2. Observe the alerts
  3. Observe Theia's notifications

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Sep 10, 2021
@vince-fugnitto vince-fugnitto added the notifications issues related to notifications label Sep 10, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I confirmed that both alert messages and notification icons are properly aligned.

@vince-fugnitto
Copy link
Member

@msujew do you plan on merging this pull-request and other UI/UX improvements soon?

@msujew
Copy link
Member Author

msujew commented Sep 27, 2021

Sure, as they are mostly fixes to issues related to #9864, I would like to have them included before Thursday. I can merge them today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notifications issues related to notifications ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alert-message: update icon alignment
2 participants