Properly render 'expand' and 'collapse' action on notification

[martin-fleck-at]

What it does

• Fix assignment of class names
• Scale icons to better fit the 'close icon'
  -- Remove hover background as due to the scaling it looks weird
  -- Use scaling as indicator instead

Fixes #10470

How to test

1. Produce a message over 500 characters (for example through a sample menu contribution)
2. See that the expand/collapse action is there and working

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[martin-fleck-at]

@vince-fugnitto Thank you for your fast review! I removed the adaptation again and just reduced the scaling a bit to make the icon size match the close icon a bit better. If you want I can remove that as well though. I double checked and I actually made the collapse/expand an action item which it was not before. Without that we do not have a background on which the scaling looked weird.

[vince-fugnitto]

@martin-fleck-at I haven't tested your latest changes yet, but based on the gif you sent something still looks incorrect. The behavior should be like the close icon, and align with vscode:

expand-icon.mp4

[martin-fleck-at]

@vince-fugnitto Got it! I updated the change but I removed the scaling now because otherwise it looks weird:

(without scaling and submitted)

(with the scaling defined in master)

[msujew]

Great, thanks for taking care of that.

Something didn't seem quite right about the direction of the chevron both in expanded and collapsed form. I took a look at how VSCode handles this. Seems like my intuition proved correct :)

Collapsed:

Expanded:

Do you mind adjusting the rotation of the chevron to align with VSCode? Afterwards, this looks good to go.

[martin-fleck-at]

@msujew Very good catch! Thank you! I aligned the chevron direction accordingly:

[msujew]

Thanks, looks great!

• The icon is visible again after your changes. (compared to master)
• The chevron does not increase its size on hover/click.
• The chevron rotation is aligned with vscode for expansion/collapse/hover.

[vince-fugnitto]

The changes look good to me 👍
The only difference I noticed was that the icons were only visible on hover in vscode, but we do not need to handle that in this pull-request.