Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secondary-window: add electron support #11642

Closed
vince-fugnitto opened this issue Sep 8, 2022 · 1 comment · Fixed by #12481 · May be fixed by eclipsesource/theia#49
Closed

secondary-window: add electron support #11642

vince-fugnitto opened this issue Sep 8, 2022 · 1 comment · Fixed by #12481 · May be fixed by eclipsesource/theia#49
Assignees
Labels
electron issues related to the electron target secondary-window issues related to multi or secondary window support

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The issue tracks a known limitation from #11048, where secondary or multi windows is not supported for electron. The goal is to add proper support for the desktop use-case which already has code in place but is not yet enabled.

Additional Info:

@vince-fugnitto vince-fugnitto added electron issues related to the electron target secondary-window issues related to multi or secondary window support labels Sep 8, 2022
tsmaeder added a commit to tsmaeder/theia that referenced this issue Sep 14, 2022
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

Contributed on behalf of ST Microelectronics.

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder self-assigned this Sep 14, 2022
tsmaeder added a commit to tsmaeder/theia that referenced this issue Oct 12, 2022
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

Contributed on behalf of ST Microelectronics.

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue Oct 13, 2022
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.
Since we cannot reliably prevent closing windows in the browser case,
we either save or discard unsaved changes according to the autosave
settings

Contributed on behalf of ST Microelectronics.

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue Oct 14, 2022
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.
Since we cannot reliably prevent closing windows in the browser case,
we either save or discard unsaved changes according to the autosave
settings

Contributed on behalf of ST Microelectronics.

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue May 3, 2023
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

To enable this properly, dialog support has been extended to work with
secondary windows, including support for the StylingService in secondary
windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue May 3, 2023
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

To enable this properly, dialog support has been extended to work with
secondary windows, including support for the StylingService in secondary
windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue May 24, 2023
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

To enable this properly, dialog support has been extended to work with
secondary windows, including support for the StylingService in secondary
windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit to tsmaeder/theia that referenced this issue Jun 2, 2023
Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

To enable this properly, dialog support has been extended to work with
secondary windows, including support for the StylingService in secondary
windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this issue Jun 2, 2023
Fixes #11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.

To enable this properly, dialog support has been extended to work with
secondary windows, including support for the StylingService in secondary
windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@seltzered
Copy link

FYI, I noticed the readme (https://github.com/eclipse-theia/theia/blob/ac0c246fbcd439c259b4778e41199708d4354899/packages/secondary-window/README.md) still says
"The extension is currently only suitable for use in browser applications because there are some unresolved issues with Electron." - is this still correct?

I'm noticing (on Electron on Linux , Theia 1.53.2), secondary-window appears functional in the latest theia-blueprint, but in my own app ( https://github.com/seltzered/beancolage ) it seems to open the secondary window but just appears as a blank window. Will try to debug further, not seeing anything really obvious at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target secondary-window issues related to multi or secondary window support
Projects
None yet
3 participants