Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secondary-window: Respect autoSave #11646

Closed
lucas-koehler opened this issue Sep 8, 2022 · 4 comments
Closed

secondary-window: Respect autoSave #11646

lucas-koehler opened this issue Sep 8, 2022 · 4 comments
Assignees
Labels
secondary-window issues related to multi or secondary window support

Comments

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Sep 8, 2022

Feature Description:

The issue tracks a known limitation from #11048 that webviews (esp. custom editors) in secondary windows do not respect the autoSave option.

Steps to Reproduce:

  1. start the browser-app with the custom-editor-sample extension
  2. start the application with exampleFiles as a workspace
  3. ensure that autoSave is off
  4. open example.cscratch
  5. add/remove entries in the file - confirm the file is dirty and closing the file prompts users
  6. open example.cscratch in a secondary window
  7. add/remove entries in the file - no visual indicator that the file is dirty
  8. attempt to close the dirty window - the window is closed, and a dialog appears after the fact in the main window (related secondary-window: Open dialogs in the secondary window #11647)
  9. if you use cancel in the dialog the file can never be re-opened unless the app is restarted.
Screen.Recording.2022-09-19.at.8.12.17.AM.mov
@vince-fugnitto vince-fugnitto added the secondary-window issues related to multi or secondary window support label Sep 8, 2022
@tsmaeder tsmaeder self-assigned this Sep 14, 2022
@tsmaeder
Copy link
Contributor

@lucas-koehler by "respecting autosave" you mean that there is no dialog asking to save when the editor is closed when dirty? If so, this is a problem that existed before.

@lucas-koehler
Copy link
Contributor Author

I believe this was discovered by vince and means that the auto save was not executed after a change.
@vince-fugnitto Do you remember details on this, i.e. what didn't work and which extension you used when discovering this?

@vince-fugnitto
Copy link
Member

@lucas-koehler @tsmaeder I updated the pr with additional steps to reproduce the bug.

@tsmaeder
Copy link
Contributor

tsmaeder commented May 4, 2023

Done as part of #11642

@msujew msujew mentioned this issue Aug 25, 2023
2 tasks
@tsmaeder tsmaeder closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
secondary-window issues related to multi or secondary window support
Projects
None yet
Development

No branches or pull requests

3 participants