Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

use example workspace when opening project in Gitpod #70

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

marcdumais-work
Copy link
Contributor

Signed-off-by: Marc Dumais [email protected]

What it does

ATM the workspace for the test application is not set correctly. Since we already have such a workspace in the repo, let's use it.

How to test

Open the PR in Gitpod. After it's built, the test application will launch. Verify that it's using our example workspace.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea!
I tested and it works correctly, when opening the pull request in Gitpod the example workspace is used.

@@ -6,6 +6,8 @@

The workspace provides an easy and reproducible way to test the functionality present in the `@theia/cpp-debug` extension.

note: ATM debugging does not work in Gitpod. Since GDB uses ptrace to attach to the debuggee and ptrace requires the docker container to be started with special permissions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] typo on debugee (debugger)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not a typo :)

https://en.wiktionary.org/wiki/debuggee

Haha I was wondering if you mean the debuggee or the debugger itself 🙈

@marcdumais-work marcdumais-work merged commit f86474d into master Nov 13, 2019
@marcdumais-work marcdumais-work deleted the gitpod-workspace branch November 13, 2019 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants