Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

[cpp] move the '@theia/cpp' extension #69

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #62

  • moves the @theia/cpp extension from the main repository.
  • updates to the @theia/cpp documentation.
  • updates to configurations for mocha tests.

How to test

  • verify that the CI passes and tests are executed.
  • perform a sanity check that the application runs.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

Fixes #62

- moves the `@theia/cpp` extension from the main repository.
- updates to the `@theia/cpp` documentation.
- updates to configurations for `mocha` tests.

Signed-off-by: vince-fugnitto <[email protected]>
@marcdumais-work
Copy link
Contributor

@vince-fugnitto would you mind rebasing? I'd like to have the PR I just merged included - I'll then record my review of this PR using Gitpod for potential use in the demo.

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto would you mind rebasing? I'd like to have the PR I just merged included - I'll then record my review of this PR using Gitpod for potential use in the demo.

I started the process of rebasing just as #70 was merged :)

@vince-fugnitto
Copy link
Member Author

The PR has been rebased on master.

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince!

@vince-fugnitto vince-fugnitto merged commit d7d1adb into master Nov 18, 2019
@vince-fugnitto vince-fugnitto deleted the vf/copy-cpp branch November 18, 2019 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpp] move 'cpp' extension from main repository
2 participants