Make build work with Java17 #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * align POM with CONTRIBUTING (enforce Java11) * up Maven requirement to 3.8.4+ * use javac release flag (instead of source/target), remove animal sniffer * fix enforcer override (was not working, as parent POM defined it in plugin not pluginMgmt section) * update to latest plugins
Changes: * update felix and tycho versions to latest * surefire: fixate junit47 provider, as presence of testng on classpath confuses surefire * align PDE and POM declared logging lib versions (slf4j, logback), it caused clashes * tests: exclude org.osgi:org.eclipse.osgi as it clases (on test classpath) with felix * tests: pass guiceVersion to UTs to be able to create "assumptions"
kwin
reviewed
Oct 29, 2022
Closed
kwin
requested changes
Jan 10, 2023
| @@ -17,19 +17,19 @@ | |||
| <location type="Maven" includeSource="true"> | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-api</artifactId> | |||
| <version>1.6.4</version> | |||
There was a problem hiding this comment.
If those dependency changes are not strictly necessary for Java 17 let us remove those. They are potentially backwards-incompatible.
There was a problem hiding this comment.
If I undo these changes, I get errors in tests (LogsTest.testProductionLogging:38 » IllegalState org.slf4j.LoggerFactory could not be successfully initialized. See also http://www.slf4j.org/codes.html#unsuccessfulInit)
|
Frankly, I'd drop this PR and rather continue with #71 that incorporates this one as well.... |
|
Superseded by #71 |
cstamas
added a commit
to eclipse-sisu/sisu.plexus
that referenced
this pull request
Mar 20, 2023
In short: now build works on both, Java 11 and Java 17 (tested with 11 and 17 Temurin on Linux). Similar to eclipse-sisu/sisu-project#61 and similarly, once this merged removal of Tycho is pending. Changes: * update GH workflow to use mvnw (instead of implicitly provided mvn by setup-java) * update wrapper to 3.2.0 and Maven to 3.9.1 * update all build plugins to their latest versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short: now build works on both, Java 11 and Java 17 (tested with 11 and 17 Temurin on Linux).
Also, build (plugins and tooling) is updated as well, dependencies are NOT touched except logging: they are set to slf4j 1.7.36 and logback 1.1.11. Reason is that (in tests) they were "crossed": slf4j 1.6 was used with 1.1.11 logback (while logback 1.1.x requires 1.7.x slf4j). So, dependencies can be set back (slf4j 1.6.x and logback 1.0.0) but then it needs to be consequently set (target AND test POM).
Changes:
release=7flag (instead of source/target+sniffer), remove animal snifferJava 17 changes (commit 8fa9020):
testContainerLookupUT fails on Java 17 + Guice4 (did not look deeper), is disabled on that combo