-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreConstruct PreDestroy should be own annotations #58
Comments
In short, this would allow users of sisu (like Maven) to not include jsr250 annotations on CP, but directly use SISU annotations, just the very same way as with Typed, Priority or Nullable |
Good idea, thanks for the example |
"own" annotations for Lifecycle as well (while do support JSR250 if present). This closes eclipse-sisu#58
The indirect goal of this issue is targeting Maven: goal is to remove the annotation dependencies from Maven Core, as that caused troubles in past (leakage), but also confuses developers that Maven is full CDI, which is not. Sisu is really "internal detail" of Maven, so Maven (internally) should use Sisu specific lifecycle annotations (as they are used in Maven Core already), and not JSR250 annotations, as that just spreads confusion among other devs. |
Just like other annotations like Typed, Priority add "own" annotations for Lifecycle as well (while do support JSR250 if present). This closes #58
Just like Description, and sisu should stop pulling in "unpopular" dependencies like javax stuff for only those two annotations. Maybe make the behave in similar way how Sisu;s
Nullable
is working (annotation from several packages are all recognized as Nullable annotation)The text was updated successfully, but these errors were encountered: