Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - fix deadlock with NativeSail #1319

Closed
hmottestad opened this issue Mar 6, 2019 · 1 comment
Closed

SHACL - fix deadlock with NativeSail #1319

hmottestad opened this issue Mar 6, 2019 · 1 comment
Assignees
@hmottestad
Labels
📦 SHACL affects the SHACL validator
Milestone
2.5.0

Comments

@hmottestad
Copy link
Contributor

There is a deadlock when using NativeSail (that should also be applicable to MemoryStore) when using parallel validation.
@hmottestad
Copy link
Contributor Author

The deadlock can be reproduced by changing from MemoryStore to NativeStore in the AbstractShaclTest and enabling parallel after init().

hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 6, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1319 super.prepare() as final step to stop it fro…
53890be 
…m locking until commit()

Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 6, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1319 added a test
f3ea852 
Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad hmottestad mentioned this issue Mar 6, 2019
Merged
@hmottestad hmottestad self-assigned this Mar 6, 2019
@hmottestad hmottestad added the 📦 SHACL affects the SHACL validator label Mar 6, 2019
@hmottestad hmottestad added this to the 2.5.0 milestone Mar 6, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 7, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
7c81edb 
* develop: (25 commits)
  eclipse-rdf4j/rdf4j#1319 added a test
  eclipse-rdf4j/rdf4j#1319 super.prepare() as final step to stop it from locking until commit()
  fix init and fix test
  eclipse-rdf4j/rdf4j#1315 make parallel validation disabled by default and log warning
  typo Jeen found
  restore javadocs
  fixup pom
  initialize() still needs to call init() even though initialize() is deprecated
  eclipse-rdf4j/rdf4j#1314 support for NativeStore
  eclipse-rdf4j/rdf4j#1312 more caching
  eclipse-rdf4j/rdf4j#1312 fix copyright headers and cleanup reuse code in nodeshape
  eclipse-rdf4j/rdf4j#1306 support for sh:class and sh:or
  eclipse-rdf4j/rdf4j#1306 support in maxCount
  eclipse-rdf4j/rdf4j#1306 support minCount
  eclipse-rdf4j/rdf4j#1306 initial implementation
  optimized imports
  eclipse-rdf4j/rdf4j#1307 some cleanup
  eclipse-rdf4j/rdf4j#1307 fix erronous close
  eclipse-rdf4j/rdf4j#1307 fix close issues
  eclipse-rdf4j/rdf4j#1307 fixed illegalstateexception
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@hmottestad