This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Issues/1319 shacl deadlock #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m locking until commit() Signed-off-by: Håvard Ottestad <[email protected]>
Signed-off-by: Håvard Ottestad <[email protected]>
|
@jeenbroekstra I managed to find out what was causing the deadlock. At some point down the line of prepare() there is a semaphore.lock() without a corresponding unlock(). There is an unlock(), but I think it's called from somewhere else, as part of a close() process. Every once in a while we would then get a deadlock (and never when debugging). Solution id to first validate all the data and then call super.prepare(). I'm not sure this fixes all cases of deadlock, but I haven't been able to produce any others. Are you comfortable with pushing this into the 2.5 release, or do you want to wait for a 2.5.x or 3.0? |
hmottestad
commented
Mar 6, 2019
| } | ||
| }finally { | ||
| super.prepare(); | ||
| previousStateConnection.prepare(); |
There was a problem hiding this comment.
super.prepare();
previousStateConnection.prepare();
As the final step in prepare()
|
Looks good, great find! Let's merge this in. |
abrokenjester
approved these changes
Mar 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses GitHub issue: eclipse-rdf4j/rdf4j#1319 .
Briefly describe the changes proposed in this PR: