Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline creation of ShaclSail #1113

Closed
abrokenjester opened this issue Oct 9, 2018 · 1 comment
Closed

Streamline creation of ShaclSail #1113

abrokenjester opened this issue Oct 9, 2018 · 1 comment
Assignees
@abrokenjester
Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Milestone
2.5.0

Comments

@abrokenjester
Copy link
Contributor

From @jeenbroekstra on April 5, 2018 8:8

Currently, initialization of a new ShaclSail requires creates a new SailRepository containing the rules, and then supplying that repository as a constructor argument to the ShaclSail, together with the actual sail on top of which the shacl sail is stacked.

This is overly complex on multiple levels (plus there is the possibility of side effects: what happens if the rules repository is changed?), so this should be simplified. Preferably, the rules should be supplied as a Model (or directly as a file reference) instead of a repository. If rule changes are required that should ideally be handled via the ShaclSail itself.

Copied from original issue: eclipse/rdf4j-storage#67
@abrokenjester abrokenjester self-assigned this Oct 9, 2018
@abrokenjester abrokenjester added 📶 enhancement issue is a new feature or improvement 📦 SHACL affects the SHACL validator labels Oct 9, 2018
@abrokenjester
Copy link
Contributor Author

From a user interface perspective, I think it would be easiest if the rules reside in a special named graph. Whether we physically store them in a separate database or actually in a context in the same store as the data is something that the ShaclSail can then decide internally.

@abrokenjester abrokenjester mentioned this issue Oct 24, 2018
Closed
abrokenjester added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Oct 28, 2018
@abrokenjester
eclipse-rdf4j/rdf4j#1113 sync with dev branch
0909a55 
Signed-off-by: Jeen Broekstra <[email protected]>
@abrokenjester abrokenjester mentioned this issue Jan 13, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 16, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1113 fixed code to support loading of shacl shape…
1628cf9 
…s after initialization but with the limitations that they can not be modified once they are loaded. Also added an exception if someone attempts to validate without having added shapes.

Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 16, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1113 option for disabling NoShapesLoadedException
c3b523a 
Signed-off-by: Håvard Ottestad <[email protected]>
abrokenjester added a commit that referenced this issue Jan 20, 2019
@abrokenjester
GH-1113 added shared constant vocabulary for SHACL shape graph
912ff8a
abrokenjester added a commit to eclipse-rdf4j/rdf4j-testsuite that referenced this issue Jan 20, 2019
@abrokenjester
eclipse-rdf4j/rdf4j#1113 fixed test for sail constructor refactor
47a84ea
This was referenced Jan 20, 2019
Merged
Merged
abrokenjester pushed a commit that referenced this issue Jan 20, 2019
Merge pull request #1250 from eclipse/issues/GH-1113-shacl-api
9eeb84c 
GH-1113 added shared constant vocabulary for SHACL shape graph
abrokenjester pushed a commit to eclipse-rdf4j/rdf4j-testsuite that referenced this issue Jan 20, 2019
Merge pull request #44 from eclipse/issues/GH-1113-shacl-api
4b68eb9 
eclipse-rdf4j/rdf4j#1113 fixed test for sail constructor refactor
abrokenjester added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 20, 2019
@abrokenjester
eclipse-rdf4j/rdf4j#1113 moved graph name constant and fixed complian…
59f71f6 
…ce test setup
abrokenjester pushed a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 20, 2019
Merge pull request #146 from eclipse/issues/GH-1113-shacl-api
c337660 
eclipse-rdf4j/rdf4j#1113 shacl sail api refactoring
abrokenjester added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 20, 2019
@abrokenjester
eclipse-rdf4j/rdf4j#1113 added config and factory class for ShaclSail
411913a
@abrokenjester abrokenjester mentioned this issue Jan 20, 2019
Merged
abrokenjester pushed a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 20, 2019
Merge pull request #153 from eclipse/issues/GH-1113-shacl-api
b46c189 
eclipse-rdf4j/rdf4j#1113 added config and factory class for ShaclSail
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 20, 2019
@hmottestad
Merge branch 'develop' into issues/1109_string_based_shapes
1a5d242 
* develop:
  eclipse-rdf4j/rdf4j#1113 added config and factory class for ShaclSail
  eclipse-rdf4j/rdf4j#1113 moved graph name constant and fixed compliance test setup
  eclipse-rdf4j/rdf4j#1113 option for disabling NoShapesLoadedException
  eclipse-rdf4j/rdf4j#1113 fixed code to support loading of shacl shapes after initialization but with the limitations that they can not be modified once they are loaded. Also added an exception if someone attempts to validate without having added shapes.
  fixed shape upload and per-connection update of NodeShape list
  fixed missing license header
  refactor to remove public use of Repository API in SAIL constructor [WIP]
  revert to use of deprecated Repository.initialize() pending merge
  rename initialize() to init(), replace usage, clean up tests

Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 28, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
cd0fad0 
* develop: (54 commits)
  setting version to 3.0-SNAPSHOT
  Use diamond inference Signed-off-by:Bart Hanssens <[email protected]>
  eclipse-rdf4j/rdf4j#998 simplify tests
  Upgraded assertj-core
  eclipse-rdf4j/rdf4j#998 list supported shacl predicates, with test to make sure the list is kept up-to-date
  eclipse-rdf4j/rdf4j#998 configurations for enabling logging of diagnostic info and better javadoc
  optimize imports
  various cleanup and fix for sh:or
  eclipse-rdf4j/rdf4j#1113 added config and factory class for ShaclSail
  eclipse-rdf4j/rdf4j#1113 moved graph name constant and fixed compliance test setup
  fixes after rebase
  eclipse-rdf4j/rdf4j#1247 support implicit and
  eclipse-rdf4j/rdf4j#1110 support nodeKind
  eclipse-rdf4j/rdf4j#1109 support for language in
  eclipse-rdf4j/rdf4j#1109 support for pattern
  eclipse-rdf4j/rdf4j#1109 reuse plan from datatype to implement minLength and maxLength
  eclipse-rdf4j/rdf4j#998 support for nested validation results
  eclipse-rdf4j/rdf4j#998 support sh:or better
  eclipse-rdf4j/rdf4j#998 support SHACL RDF report format
  eclipse-rdf4j/rdf4j#998 log which shape caused the issue
  ...

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/Utils.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Jan 29, 2019
@hmottestad
Merge branch 'master' into issues/1249_support_prepare_in_shaclsail
308a4de 
* master: (30 commits)
  very premature implementation of the w3c shacl tests with what seems like some bugs (since they don't run correctly) and also most of this isn't even supported
  eclipse-rdf4j/rdf4j#1268 add config for setting behavior when target is undefined
  eclipse-rdf4j/rdf4j#1266 some logging issues found while writing documentation
  solr embedded now uses managed schema by default - reintroduced necessary config files
  Use diamond inference Signed-off-by:Bart Hanssens <[email protected]>
  eclipse-rdf4j/rdf4j#998 simplify tests
  Upgraded assertj-core
  eclipse-rdf4j/rdf4j#998 list supported shacl predicates, with test to make sure the list is kept up-to-date
  eclipse-rdf4j/rdf4j#998 configurations for enabling logging of diagnostic info and better javadoc
  optimize imports
  various cleanup and fix for sh:or
  eclipse-rdf4j/rdf4j#1113 added config and factory class for ShaclSail
  eclipse-rdf4j/rdf4j#1113 moved graph name constant and fixed compliance test setup
  fixes after rebase
  eclipse-rdf4j/rdf4j#1247 support implicit and
  eclipse-rdf4j/rdf4j#1110 support nodeKind
  eclipse-rdf4j/rdf4j#1109 support for language in
  eclipse-rdf4j/rdf4j#1109 support for pattern
  eclipse-rdf4j/rdf4j#1109 reuse plan from datatype to implement minLength and maxLength
  eclipse-rdf4j/rdf4j#998 support for nested validation results
  ...

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/ShaclTest.java
@abrokenjester abrokenjester added this to the 2.5.0 milestone Feb 17, 2019
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Feb 21, 2019
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
@hmottestad
Merge branch 'develop' into issues/GH-1113-shacl-api
7224be2 
* develop:
  ignore code generated during mvn install
  #1246 shutdown repo to cause error
  #1246 close unclosed resource
  #1182 use logger instead of println

Signed-off-by: Håvard Ottestad <[email protected]>
abrokenjester pushed a commit that referenced this issue Aug 22, 2019
@hmottestad
Merge branch 'develop' into issues/GH-1113-shacl-api
08353d0 
* develop:
  #998 support for nested validation results
  #998 support sh:or better
  #998 support SHACL RDF report format
  #998 log which shape caused the issue

Signed-off-by: Håvard Ottestad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@abrokenjester