Unreleased lock when shutting down ShaclSail after a validation failure

[hmottestad]

There is an unreleased lock when shutting down the ShaclSail after a validation failure.

java.lang.Throwable: Read lock 615 acquired in main
	at org.eclipse.rdf4j.common.concurrent.locks.LockManager.createLock(LockManager.java:167)
	at org.eclipse.rdf4j.common.concurrent.locks.AbstractReadWriteLockManager.createReadLock(AbstractReadWriteLockManager.java:105)
	at org.eclipse.rdf4j.common.concurrent.locks.ReadPrefReadWriteLockManager.getReadLock(ReadPrefReadWriteLockManager.java:81)
	at org.eclipse.rdf4j.sail.memory.MemorySailStore.openStatementsReadLock(MemorySailStore.java:146)
	at org.eclipse.rdf4j.sail.memory.MemorySailStore.access$200(MemorySailStore.java:56)
	at org.eclipse.rdf4j.sail.memory.MemorySailStore$MemorySailSink.<init>(MemorySailStore.java:403)
	at org.eclipse.rdf4j.sail.memory.MemorySailStore$MemorySailSource.sink(MemorySailStore.java:361)
	at org.eclipse.rdf4j.sail.base.SailSourceBranch.prepare(SailSourceBranch.java:260)
	at org.eclipse.rdf4j.sail.base.UnionSailSource.prepare(UnionSailSource.java:68)
	at org.eclipse.rdf4j.sail.base.SailSourceConnection.prepareInternal(SailSourceConnection.java:409)
	at org.eclipse.rdf4j.sail.helpers.AbstractSailConnection.prepare(AbstractSailConnection.java:406)
	at org.eclipse.rdf4j.sail.helpers.SailConnectionWrapper.prepare(SailConnectionWrapper.java:259)
	at org.eclipse.rdf4j.sail.shacl.ShaclSailConnection.prepare(ShaclSailConnection.java:148)
	at org.eclipse.rdf4j.repository.sail.SailRepositoryConnection.commit(SailRepositoryConnection.java:168)
	at org.eclipse.rdf4j.sail.shacl.ShaclTest.runTestCase(ShaclTest.java:171)
	at org.eclipse.rdf4j.sail.shacl.ShaclTest.test(ShaclTest.java:80)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

I am unable to reproduce this without the ShaclSail, but I don't see anything wrong in the ShaclSail.

This bug can not be reproduced when using IsolationLevel.NONE or SERIALIZABLE. It is reproducible with SNAPSHOT.